Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 182260 - patchset to make compile and work app-arch/zoo-2.10-r3 on Gentoo/FreeBSD
Summary: patchset to make compile and work app-arch/zoo-2.10-r3 on Gentoo/FreeBSD
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: FreeBSD (show other bugs)
Hardware: AMD64 FreeBSD
: High normal (vote)
Assignee: Gentoo/BSD Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-16 20:53 UTC by MT
Modified: 2007-08-22 13:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
zoo-2.10-gentoo-fbsd.patch (zoo-2.10-gentoo-fbsd.patch,4.77 KB, patch)
2007-06-16 20:53 UTC, MT
Details | Diff
zoo-2.10-r3.ebuild.patch (zoo-2.10-r3.ebuild.patch,398 bytes, patch)
2007-06-16 20:54 UTC, MT
Details | Diff
zoo-2.10-gentoo-fbsd.patch (zoo-2.10-gentoo-fbsd.patch,5.08 KB, patch)
2007-06-16 21:10 UTC, MT
Details | Diff
zoo-2.10-r3.ebuild.patch (zoo-2.10-r3.ebuild.patch,333 bytes, patch)
2007-06-16 21:11 UTC, MT
Details | Diff
zoo-2.10-r3.ebuild.patch (zoo-2.10-r3.ebuild.patch,333 bytes, patch)
2007-06-16 21:33 UTC, MT
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description MT 2007-06-16 20:53:17 UTC
attached there is the patchset necessary to compile zoo on g/fbsd. i have checked the freebsd ports (http://www.freebsd.org/cgi/cvsweb.cgi/ports/archivers/zoo/files/) and imported all the necessary fixes (some fixes from ports are just been applied upstream).

NOTE: the actual ebuild in portage (z00-2.10-r3.ebuild) use "emake", but it do not work well on Gentoo/FreeBSD, making the compilation fail with:

make           CFLAGS="-c -march=athlon64 -pipe -O2 -DSYS_V -DANSI_HDRS -DHAVE_MKDIR" zoo fiz
make: illegal option -- -
usage: make [-BPSXeiknqrstv] [-C directory] [-D variable]
        [-d flags] [-E variable] [-f makefile] [-I directory]
        [-j max_jobs] [-m directory] [-V variable]
        [variable=value] [target ...]
gmake: *** [linux] Error 2


using "make" instead of "emake" the problem is fixed. I'm not sure if the "make" usage is the right fix for the ebuild and actualy there is any maintainer for the package to ask about. However attached there is also the patch for the ebuild. I have tested the ebuild patch also on Gentoo/Linux and compile and work flawness.

Reproducible: Always
Comment 1 MT 2007-06-16 20:53:47 UTC
Created attachment 122264 [details, diff]
zoo-2.10-gentoo-fbsd.patch
Comment 2 MT 2007-06-16 20:54:13 UTC
Created attachment 122266 [details, diff]
zoo-2.10-r3.ebuild.patch
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2007-06-16 20:56:26 UTC
Changing emake in make is not the good thing to do. Patch rejected.

Please make sure that the makefiles always use $(MAKE) and not make to call a sub-directory make.
Comment 4 MT 2007-06-16 21:10:16 UTC
Created attachment 122267 [details, diff]
zoo-2.10-gentoo-fbsd.patch

this one correct also wrong $(MAKE) usage into makefile (thank you Flameeyes for poiting out the problem)
Comment 5 MT 2007-06-16 21:11:27 UTC
Created attachment 122269 [details, diff]
zoo-2.10-r3.ebuild.patch
Comment 6 MT 2007-06-16 21:33:41 UTC
Created attachment 122270 [details, diff]
zoo-2.10-r3.ebuild.patch
Comment 7 Roy Marples (RETIRED) gentoo-dev 2007-08-22 13:59:38 UTC
zoo is already keyworded ...