Building a kernel for a Blue & White G3, I enabled the option Device Drivers -> Sound -> PowerMac DMA sound support (CONFIG_DMASOUND_PMAC) which resulted in a compile-error : sound/oss/dmasound/dmasound_awacs.c:260: warning: 'struct pmu_sleep_notifier' declared inside parameter list sound/oss/dmasound/dmasound_awacs.c:260: warning: its scope is only this definition or declaration, which is probably not what you want sound/oss/dmasound/dmasound_awacs.c:261: error: variable 'awacs_sleep_notifier' has initializer but incomplete type sound/oss/dmasound/dmasound_awacs.c:262: warning: excess elements in struct initializer sound/oss/dmasound/dmasound_awacs.c:262: warning: (near initialization for 'awacs_sleep_notifier') sound/oss/dmasound/dmasound_awacs.c:262: error: 'SLEEP_LEVEL_SOUND' undeclared here (not in a function) sound/oss/dmasound/dmasound_awacs.c:262: warning: excess elements in struct initializer sound/oss/dmasound/dmasound_awacs.c:262: warning: (near initialization for 'awacs_sleep_notifier') sound/oss/dmasound/dmasound_awacs.c: In function 'PMacIrqCleanup': sound/oss/dmasound/dmasound_awacs.c:678: warning: implicit declaration of function 'pmu_unregister_sleep_notifier' sound/oss/dmasound/dmasound_awacs.c: At top level: sound/oss/dmasound/dmasound_awacs.c:1423: error: conflicting types for 'awacs_sleep_notify' sound/oss/dmasound/dmasound_awacs.c:260: error: previous declaration of 'awacs_sleep_notify' was here sound/oss/dmasound/dmasound_awacs.c: In function 'awacs_sleep_notify': sound/oss/dmasound/dmasound_awacs.c:1427: error: 'PBOOK_SLEEP_NOW' undeclared (first use in this function) sound/oss/dmasound/dmasound_awacs.c:1427: error: (Each undeclared identifier is reported only once sound/oss/dmasound/dmasound_awacs.c:1427: error: for each function it appears in.) sound/oss/dmasound/dmasound_awacs.c:1480: error: 'PBOOK_WAKE' undeclared (first use in this function) sound/oss/dmasound/dmasound_awacs.c:1551: error: 'PBOOK_SLEEP_OK' undeclared (first use in this function) sound/oss/dmasound/dmasound_awacs.c: In function 'dmasound_awacs_init': sound/oss/dmasound/dmasound_awacs.c:3074: warning: implicit declaration of function 'pmu_register_sleep_notifier' From the look of it (and with hindsight) the correct solution is to not enable that option and to instead use the ALSA driver, but "PowerMac DMA sound support" should be either fixed, removed or at least marked as deprecated. Reproducible: Always Steps to Reproduce:
Could you please try applying the patch (see attachment) and see if that fixes it for you?
Created attachment 122273 [details, diff] patch to fix CONFIG_DMASOUND_PMAC
Maarten, even though the user is unresponsive we should send these upstream anyway. Poke me on IRC sometime (you might have to do this more than once with a variety of sharp objects as work is pretty busy)
(In reply to comment #3) > the user is unresponsive :\ Apologies. Have been busy/sick/etc/life/etc/excuse_37. I hit (what appears to be) a weird NFS-mounted-root timeout bug with a Grape iMac which diverted me from following up this (and the other related) bug(s). I should be able to get back on it sometime soon... (although I have a murky memory that the patch didn't compile for me and that I wanted to look into it in more depth later(TM). I'll set up the box now and see what happens...)
This driver is slated for removal in 2.6.24, in favour of the ALSA one. If no objections come up to to that removal on the LKML, we should close this bug in a week's time or so, as patches won't be accepted now. So, ignore this bug for now, but please do test the patches on the other ones that you reported.
Tested, patch appears to work. Thanks for patch and for info re: upstream activity. (Sorry about the delay. Will try to get at other bugs also...)
As advised, this driver is being removed in 2.6.24. There was no objections to its removal on the LKML as of this writing. http://lkml.org/lkml/2007/7/23/373
