Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 181829 - media-sound/muine-0.8.7 fails to build with >=flac-1.1.3
Summary: media-sound/muine-0.8.7 fails to build with >=flac-1.1.3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Peter Johanson (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 152007
  Show dependency tree
 
Reported: 2007-06-12 21:28 UTC by Alexis Ballier
Modified: 2007-07-12 14:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
muine-0.8.7-flac-1.1.3.patch (muine-0.8.7-flac.patch,2.25 KB, patch)
2007-07-11 10:38 UTC, Samuli Suominen (RETIRED)
Details | Diff
muine-0.8.7-flac-1.1.3.patch (muine-0.8.7-flac.patch,2.33 KB, patch)
2007-07-12 14:47 UTC, Samuli Suominen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2007-06-12 21:28:16 UTC
last round of checks before unmasking >=flac 1.1.3 :

make[3]: Entering directory `/var/tmp/portage/media-sound/muine-0.8.7/work/muine-0.8.7/libmuine'
/bin/sh ../libtool --tag=CC   --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I.. -DG_LOG_DOMAIN=\"libmuine\" -DGNOMELOCALEDIR=\""/usr/share/locale"\" -DORBIT2=1 -pthread -D_REENTRANT -DPNG_NO_MMX_CODE -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib64/gnome-vfs-2.0/include -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12    -L/usr/include     -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -Werror  -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGNOME_DISABLE_DEPRECATED    -march=athlon64 -O2 -pipe -MT metadata.lo -MD -MP -MF .deps/metadata.Tpo -c -o metadata.lo metadata.c
 x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I.. -DG_LOG_DOMAIN=\"libmuine\" -DGNOMELOCALEDIR=\"/usr/share/locale\" -DORBIT2=1 -pthread -D_REENTRANT -DPNG_NO_MMX_CODE -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib64/gnome-vfs-2.0/include -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -L/usr/include -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -Werror -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGNOME_DISABLE_DEPRECATED -march=athlon64 -O2 -pipe -MT metadata.lo -MD -MP -MF .deps/metadata.Tpo -c metadata.c  -fPIC -DPIC -o .libs/metadata.o
cc1: warnings being treated as errors
metadata.c: In function 'assign_metadata_flac':
metadata.c:832: warning: implicit declaration of function 'FLAC__stream_decoder_set_read_callback'
metadata.c:832: warning: nested extern declaration of 'FLAC__stream_decoder_set_read_callback'
metadata.c:833: warning: implicit declaration of function 'FLAC__stream_decoder_set_write_callback'
metadata.c:833: warning: nested extern declaration of 'FLAC__stream_decoder_set_write_callback'
metadata.c:834: warning: implicit declaration of function 'FLAC__stream_decoder_set_metadata_callback'
metadata.c:834: warning: nested extern declaration of 'FLAC__stream_decoder_set_metadata_callback'
metadata.c:835: warning: implicit declaration of function 'FLAC__stream_decoder_set_error_callback'
metadata.c:835: warning: nested extern declaration of 'FLAC__stream_decoder_set_error_callback'
metadata.c:840: warning: implicit declaration of function 'FLAC__stream_decoder_set_client_data'
metadata.c:840: warning: nested extern declaration of 'FLAC__stream_decoder_set_client_data'
metadata.c:847: warning: implicit declaration of function 'FLAC__stream_decoder_init'
metadata.c:847: warning: nested extern declaration of 'FLAC__stream_decoder_init'
make[3]: *** [metadata.lo] Error 1
make[3]: Leaving directory `/var/tmp/portage/media-sound/muine-0.8.7/work/muine-0.8.7/libmuine'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/media-sound/muine-0.8.7/work/muine-0.8.7/libmuine'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/media-sound/muine-0.8.7/work/muine-0.8.7'
make: *** [all] Error 2



I dunno what this -Werror is doing here, but that's a good thing since from what I see in the code, it's not compatible with the new flac api.
Please leave that bug open until we have a fix (and yes, I know it's ~depping to flac 1.1.2, but the plan is to unmask newer versions ;) )

I'll try to provide a patch
Comment 1 Peter Johanson (RETIRED) gentoo-dev 2007-06-12 21:38:50 UTC
Alexis: muine in SVN has a fix for working with the new FLAC (when you also have a gstreamer that supports it). If you're going to do a patch, I suggest you pull the one from there. Otherwise, maybe I can get off my *ss and actually do a muine release, so you don't have to worry about it.
Comment 2 Alexis Ballier gentoo-dev 2007-06-13 05:12:07 UTC
(In reply to comment #1)
> Alexis: muine in SVN has a fix for working with the new FLAC (when you also
> have a gstreamer that supports it). If you're going to do a patch, I suggest
> you pull the one from there. Otherwise, maybe I can get off my *ss and actually
> do a muine release, so you don't have to worry about it.


Good to know ;) I was only at the first step of those checks, i.e., having appropriate blockers for bug #152007 . Anyway, you probably know better than me what's more appropriate between a release and a patch. Our gst-plugins patches have been merged for the 0.10.6 release. And now that debian's flac maintainer has woken up and packaged flac 1.1.4, breaking half of unstable packages depending on it, you'll probably have such requests from them aswell.
Here there is no rush, flac is masked, we're almost done with the migration but I won't unmask it until I'm sure 100% of the packages depending on flac are fine.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2007-07-11 10:38:03 UTC
Created attachment 124539 [details, diff]
muine-0.8.7-flac-1.1.3.patch

Patch from upstream SVN.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2007-07-11 10:40:08 UTC
Changes in ebuild.. 

flac dep from ~ to >=
epatch "${FILESDIR}"/${P}-flac-1.1.3.patch to src_unpack

Unfortunately I'm not able to test it right now because of unrelated issue with dev-dotnet/libgdiplus-1.2.4 which fails to build and is a dep for muine.

So, please test & commit so we can move forward.
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2007-07-12 14:47:23 UTC
Created attachment 124651 [details, diff]
muine-0.8.7-flac-1.1.3.patch

Unified diff, tested one.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2007-07-12 14:51:25 UTC
fixed in cvs, thanks