Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 181288 - media-sound/lastfmplayer-1.1.3-r2 - endian problem causes wrong playback on big endian based systems
Summary: media-sound/lastfmplayer-1.1.3-r2 - endian problem causes wrong playback on b...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: PPC Porters
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-08 10:23 UTC by Albert Zeyer
Modified: 2007-07-04 00:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
lastfm_mp3transcode.diff (lastfm_mp3transcode.diff,954 bytes, patch)
2007-06-08 10:24 UTC, Albert Zeyer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Zeyer 2007-06-08 10:23:35 UTC
Hi

I already have made a patch for this issue :)

Will attach it...

Except for this problem (which I fixed now), lastfmplayer works stable here, so please add ~ppc (and perhaps other other big endian systems; but I only tested PPC).
Comment 1 Albert Zeyer 2007-06-08 10:24:19 UTC
Created attachment 121486 [details, diff]
lastfm_mp3transcode.diff
Comment 2 Joe Jezak (RETIRED) gentoo-dev 2007-06-28 14:23:39 UTC
Thanks for the patch!  I've updated it for the new version too.  Please make sure to submit this for inclusion upstream!

Thanks!
Comment 3 Albert Zeyer 2007-07-03 14:09:36 UTC
I just tested the new version 1.3.0.58 and it seems that the patch is not needed there. That means, with applied patch, you again have the bytes switched one time too often and you again got the wrong playblack. It seems that they have switched the bytes elsewhere in 1.3.0.58 (I haven't took a more deeper look at the code to determit where in detail).

I have tested 1.3.0.58 without the patch and it works good. So the simple solution: Use the patch for 1.1.3 but remove it for 1.3.0.58.
Comment 4 Joe Jezak (RETIRED) gentoo-dev 2007-07-04 00:59:03 UTC
Whoops. :p  I only tested it on 1.1.3-r2, I've removed the newer one, thanks.