181193 – net-misc/vde initscript broken if VDE_MODPROBE_TUN==no

Bug 181193 - net-misc/vde initscript broken if VDE_MODPROBE_TUN==no

Summary: net-misc/vde initscript broken if VDE_MODPROBE_TUN==no

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal
Assignee:	Stefan Schweizer (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-06-07 12:53 UTC by Giuliano Gagliardi
Modified:	2007-06-09 15:38 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Giuliano Gagliardi 2007-06-07 12:53:20 UTC

The last lines in the stop() part of the init-script are:
    [ "${VDE_MODPROBE_TUN}" == "yes" ] && modprobe -r tun
    eend $? "Failed to stop vde"
This causes stopping to always fail, when "${VDE_MODPROBE_TUN}" == "no".

Reproducible: Always

Comment 1 Jakub Moc (RETIRED) gentoo-dev

2007-06-07 18:50:40 UTC

How exactly does it cause the initscript to fail? Doesn't make sense.

Comment 2 Giuliano Gagliardi 2007-06-08 00:00:25 UTC

(In reply to comment #1)
> How exactly does it cause the initscript to fail? Doesn't make sense.
> 

$? is always 1, because the comparison failed.

Comment 3 Stefan Schweizer (RETIRED) gentoo-dev

2007-06-09 15:38:21 UTC

thanks, I think I have fixed it by moving the calls around.