We should include a USE var that would include the spellchecker at spellchecker.mozdev.org in the build of mozilla. The precedent is there with the enigmail inclusion in the ebuild, and the spellchecker is one of mozilla mails glaringly missing features. Reproducible: Always Steps to Reproduce:
I patched the spellchecker in but it doesn't compile. If anyones interested I'll attach the modified ebuild, patch and spellchecker tarball since they only have cvs downloads, however I don't know how usefull it will be since it doesn't compile. Heres the error I get. g++ -o mozSpellChecker.o -c -DOSTYPE=\"Linux2.4\" -DOSARCH=\"Linux\" -DOJI -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/editor -I../../../dist/include/content -I../../../dist/include/layout -I../../../dist/include/dom -I../../../dist/include/necko -I../../../dist/include/widget -I../../../dist/include/pref -I../../../dist/include/gfx -I../../../dist/include/txtsvc -I../../../dist/include/uconv -I../../../dist/include/unicharutil -I../../../dist/include/spellchecker -I../../../dist/include -I/var/tmp/portage/mozilla-1.3-r1/work/mozilla/dist/include/nspr -I/usr/X11R6/include -fPIC -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-long-long -march=i686 -pipe -Wno-deprecated -pthread -pipe -DNDEBUG -DTRIMMED -ffunction-sections -O2 -I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/mozSpellChecker.pp mozSpellChecker.cpp mozPersonalDictionary.cpp g++ -o mozPersonalDictionary.o -c -DOSTYPE=\"Linux2.4\" -DOSARCH=\"Linux\" -DOJI -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/editor -I../../../dist/include/content -I../../../dist/include/layout -I. ./../../dist/include/dom -I../../../dist/include/necko -I../../../dist/include/widget -I../../../dist/include/pref -I../../../dist/include/gfx -I../../../dist/include/txtsvc -I../../../dist/include/uconv -I../../../dist/include/unicharutil -I../../../dist/include/spellchecker -I../../../dist/include -I/var/tmp/portage/mozilla-1.3-r1/work/mozilla/dist/include/nspr -I/usr/X11R6/include -fPIC -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-long-long -march=i686 -pipe -Wno-deprecated -pthread -pipe -DNDEBUG -DTRIMMED -ffunction-sections -O2 -I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/mozPersonalDictionary.pp mozPersonalDictionary.cpp mozPersonalDictionary.cpp: In method `nsresult mozPersonalDictionary::Load()': mozPersonalDictionary.cpp:393: no matching function for call to `nsDerivedSafe<nsIUnicharInputStream>::Read (PRUnichar *, int, PRUint32 *)' ../../../dist/include/xpcom/nsIUnicharInputStream.h:59: candidates are: nsresult nsIUnicharInputStream::Read(PRUnichar *, unsigned int, unsigned int, PRUint32 *) mozPersonalDictionary.cpp:395: no matching function for call to `nsDerivedSafe<nsIUnicharInputStream>::Read (PRUnichar *, int, PRUint32 *)' ../../../dist/include/xpcom/nsIUnicharInputStream.h:59: candidates are: nsresult nsIUnicharInputStream::Read(PRUnichar *, unsigned int, unsigned int, PRUint32 *) mozPersonalDictionary.cpp:401: no matching function for call to `nsDerivedSafe<nsIUnicharInputStream>::Read (PRUnichar *, int, PRUint32 *)' ../../../dist/include/xpcom/nsIUnicharInputStream.h:59: candidates are: nsresult nsIUnicharInputStream::Read(PRUnichar *, unsigned int, unsigned int, PRUint32 *) make[4]: *** [mozPersonalDictionary.o] Error 1 make[4]: Leaving directory `/var/tmp/portage/mozilla-1.3-r1/work/mozilla/extensions/spellcheck/src' make[3]: *** [libs] Error 2 make[3]: Leaving directory `/var/tmp/portage/mozilla-1.3-r1/work/mozilla/extensions/spellcheck' make[2]: *** [libs] Error 2 make[2]: Leaving directory `/var/tmp/portage/mozilla-1.3-r1/work/mozilla/extensions' make[1]: *** [tier_94] Error 2 make[1]: Leaving directory `/var/tmp/portage/mozilla-1.3-r1/work/mozilla' make: *** [default] Error 2 !!! ERROR: net-www/mozilla-1.3-r1 failed. !!! Function src_compile, Line 369, Exitcode 2 !!! (no error message)
Created attachment 9819 [details] mozilla-1.3-r1.ebuild created a new use var of mozspellcheck like all the other moz* ones
Created attachment 9820 [details, diff] unix-spellcheck.patch add the spellchecker to the build
Created attachment 9821 [details] spellcheck.tar.gz untar into the files dir
I submited a bug to the spellchecker guys. See http://mozdev.org/bugs/show_bug.cgi?id=3487
I got a fix from the mozdev bug...trying it out. Will update this bug in a few hours when mozilla finishes compiling.
Ok with the fix it compiles and works. Uploading new tarball.
Created attachment 9930 [details] new spellcheck.tar.gz
Created attachment 13377 [details] mozilla-1.3-r2.ebuild Result of a diff between (bug attached) mozilla-1.3-r1.ebuild and standard mozilla-1.3-r2.ebuild.
cool, I didn't even notice there was a -r2 ebuild since I called my ebuild -r2 on my machine.
I tested the patches on Alpha and it worked for me, I am in the process of testing the latest CVS bits on the mozilla-1.4 package for Alpha as well. It would be really nice if this made it into the base mozilla package.
Created attachment 14658 [details] Patch and source to enable the spellchecker in Mozilla 1.4 To install this patch untar the file in /usr/portage/net-www/mozilla; it has been tested on Gentoo Alpha but I have no reason to believe it will have problems on Gentoo X86.
According to http://spellchecker.mozdev.org/ the spellchechecker is now in the 1.5 trunk. For 1.4, I will be posting patches for 1.4-r2 and 1.4-r3 shortly. We ought to integrate these into the mozilla default ebuild to save the duplication of effort by all the good folks who keep diffing and posting patches to this bug.
Created attachment 15546 [details] ebuild and patch for 1.4-r3 Attached is a new ebuild for mozilla 1.4-r3 which adds a new USE flag called mozspellcheck. Copy this file into /usr/portage/net-www/mozilla/. Perform tar -zxvf mozilla-1.4-r3-spellcheck_patch.tar.gz in that directory. Then perform USE="-crypt mozspellcheck" emerge /usr/portage/net-www/mozilla/mozilla-1.4-r3.ebuild. After this, the user should be able to log in as root and install the spellchecker from http://spellchecker.mozdev.org/installation.html#
I just emerged the ebuild provided here and it works great. I didn't need to set -crypt.
Is this patch still not in 1.4-r4 or am I missing something?
Since mozilla-1.5 I think that the spellchecker is included in moz by default, sorry we weren't able to do this for 1.3/1.4
