Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 180302 - net-firewall/firehol-1.256 version bump
Summary: net-firewall/firehol-1.256 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Dominik Stadler (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-30 00:28 UTC by Tim Harder
Modified: 2007-06-01 17:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Diff for compatibility for new version (diff,834 bytes, patch)
2007-05-30 12:17 UTC, Thomas Anderson (tanderson) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Harder gentoo-dev 2007-05-30 00:28:05 UTC
The new version fixed kernel 2.6.20+ compatibility issues, fixed BASH 3.2 compatibility issues, and fixed various iptables compatibility issues along with other feature updates.

See the official website for more details.
Comment 1 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-05-30 12:16:01 UTC
Attaching a patch:

Also some notes: 

1) In FILESDIR the init.d script is mislabeled. It is "firehol.initrd" but should be "firehol.init.d"
2) What is with the patching for new versions!? I removed that and used the stock tarball from upstream.
3) Had to change the ${S} because I didn't patch it.
Comment 2 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-05-30 12:17:36 UTC
Created attachment 120703 [details, diff]
Diff for compatibility for new version
Comment 3 Dominik Stadler (RETIRED) gentoo-dev 2007-06-01 14:05:51 UTC
I have added the new version, please give it a try as soon as it is available on the mirrors. I did the following differently to what you had in the attachment:

- I kept the patch for printf, not sure if this is fixed somehow differently in the upstream version and I was not able to verify, so I kept these changes for now
- the name of firehol.initrd is just what is stored under "files", the "newinitd" in the ebuild names it correctly when installing into /etc/init.d/, or do I miss something here?
- setting ${S} can go away completely
- I use ${P} where possible again as we are using the latest version of firehol again
Comment 4 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-06-01 17:08:49 UTC
Yeah, I realized that I didn't really need ${S} anymore and was thinking about putting a patch up, but figured you smart devs would figure it out ;-)

The reason I wanted to change the init.d script name is because it is deceiving in ${FILESDIR}. It makes it appear as though it is an initrd image(initial ramdisk) instead of a script. Just a matter of taste, I guess, but it might confuse a user.