Bug 1802 – pnm2ppa update

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Paul de Vrieze (RETIRED) 2002-04-15 10:36:57 UTC]

Yesterdays patch was incomplete, (forgot to define __GNU_SYSTEM) don't know if
its critical. Also the ebuild makes a pnm2ppa that segfaults because of a
missing define in the CFLAGS

[Comment 1 Paul de Vrieze (RETIRED) 2002-04-15 10:38:05 UTC]

Created attachment 571 [details, diff]
Diff file on the ebuild

The new ebuild defines an extra make flag. This way pnm2ppa doesn't segfault
when running

[Comment 2 Paul de Vrieze (RETIRED) 2002-04-15 10:40:42 UTC]

Created attachment 572 [details]
Replacement patchfile for pnm2ppa-r3

This is a replacement patch file. It is not a patch of the patch anymore
because that diff also sees a lot of filetime changes that are IMHO not
relevant. The only change though is in pnm2ppa.c, it now also defines 
_GNU_SOURCE.

[Comment 3 Seemant Kulleen (RETIRED) 2002-04-15 17:46:17 UTC]

I did not see a patch.  I saw the ebuild file in the attachment.  The only
difference between that and the -r2 ebuild is an extra definition in CFLAGS.  Is
that all that is different? I had assumed that you 
had attached a diff to the pnm2ppa source as well, or am I mistaken in my
assumption?

Thanks

[Comment 4 Paul de Vrieze (RETIRED) 2002-04-16 02:27:07 UTC]

 Oops I attached the wrong file. You can change it yourself. 
On the 5th line of pnm2ppa.c (before include <string.h>) there needs to be a  
line: #define _GNU_SOURCE 
 
This stops a warning in the compile from appearing. (I didn't check wether it  
actually ran well without this patch) 
 
Paul 
 

[Comment 5 Seemant Kulleen (RETIRED) 2002-04-16 07:41:49 UTC]

Any chance I can get you to test that?

[Comment 6 Paul de Vrieze (RETIRED) 2002-04-16 07:58:48 UTC]

If you wait a couple of hours, I'll test it (with the ebuild patch as it 
segfaults without). It should be done anyway though. The new version works by 
the way. 

[Comment 7 Seemant Kulleen (RETIRED) 2002-04-17 03:42:27 UTC]

Thanks for this fix :)