The x11-themes/commonbox-styles-extra requires media-gfx/xv which is a shareware program. I think that a better solution would be to use bsetbg from x11-misc/commonbox-utils for all styles which employ a rootCommand. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Created attachment 9690 [details, diff] diff of changed commbox-styles-extra style files
Comment on attachment 9690 [details, diff] diff of changed commbox-styles-extra style files I've changed all style files that use `xv' to use `bsetbg' and tested. All of them worked correctly in my tests. My tests used bsetbg with Esetroot since that is what I normally use.
Esetroot is not an option to consider. I'm not prepared to make Eterm a dependancy of commonbox-*. bsetbg is just a shell wrapper script, as you're aware, so relying on it alone isn't an option. I'm aware of programs like xsetroot, bsetroot, and other that could work, but xv does better at scaling images then the others. Since this is also an extra, non-required package. which does not prevent functional use of any package, I'm not currently inclined to make any changes. I'll keep it in mind for the next major version revision though.
I completely agree that making Eterm (for Esetroot) a dependency is not an acceptable solution. Since bsetbg *is* only a wrapper, I do think that depending on it is a practical solution. It allows the user the flexibility to use the program of his choosing and is his responsibility to see that it is installed. If this is especially a problem, perhaps adding a message (via einfo?) to the ebuild informing the user to configure bsetbg would be helpful? What is most problematic to me is that commonbox-styles-extra is depending on a non-free, shareware program which prevents someone who refuses to use any non-free software from using this ebuild. This, sadly, `taints' what would otherwise be a wholly Free ebuild. Regarding a suitable replacement for xv, xli would be perfect since it has all of the functionality with regards to scaling images. Unfortunately, xli hasn't worked correctly for me the last time I had tried it on Gentoo Linux. I have used it successfully on other Linux distributions in the past. I plan to submit a bug report for it when I get the time. Perhaps when any bugs there may be in it are corrected, it can be used in place of xv. Thank you for your time and consideration.
I have fluxbox installed and came across this bug too. Trying the patch kindly provided by Mr. Fultz, I discovered while attempting to emerge the necessary commonbox-utils pkg that it too depends on xv. Looking for an alternative to xv, I saw that there are several and I found that qiv works perfectly well for loading and scaling images for the styles in commonbox-styles-extra that need it. I notice that commonbox-utils-0.5 (currently unstable) depends not on xv but on feh and I expect that feh would work well for the extra styles too. I agree with Mr. Fultz that the commonbox-styles-extra pkg is tainted by this dependency on xv. Clearly it is easily remedied and I was surprised to see the justification that xv "does better at scaling images than the others". Even if that's true it seems contrary to the Gentoo philosophy to hardwire that opinion into an ebuild. It may not be an 'essential' package and I know this isn't gnu.org and you could say the user can easily fix it him/herself anyway but I'd feel a lot happier about recommending Gentoo to others if this bug didn't have a "WONTFIX" resolution attached to it.
