Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 17935 - sys-kernel/gentoo-sources-2.4.20-r2.ebuild MAJOR error caused by minor issue
Summary: sys-kernel/gentoo-sources-2.4.20-r2.ebuild MAJOR error caused by minor issue
Status: RESOLVED LATER
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High blocker (vote)
Assignee: x86-kernel@gentoo.org (DEPRECATED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-21 09:57 UTC by Paul Belt
Modified: 2003-03-22 02:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Belt 2003-03-21 09:57:01 UTC
# This is the ratified crypt USE flag, enables IPSEC & USAGI
    if [ -z "`use crypt`" ]; then
        einfo "No Cryptographic support, dropping patches..."
        for file in 6* 7* 8* ;do
            einfo "Dropping ${file}..."
            rm -f ${file}
        done
    else
        einfo "Cryptographic support enabled..."
    fi

With that and the current patch-set... The following would be deleted if crypt isn't set in USE:
600_usagi-stable_20030214  7*_iptables-* 800_loop-jari-2.4.20 801_super-freeswan-1.99-kb3

NOT the expected behavior.

Reproducible: Always
Steps to Reproduce:

1.
2.
3.
Comment 1 Jay Pfeifer (RETIRED) gentoo-dev 2003-03-21 15:12:11 UTC
With the mix of USAGI, IPsec & update pom, the dropping of this is neccessary to avoid patch 
issues. Therefore, I have uploaded a new ebuild (should be available shortly) that will ensure 
none of the "crypt" patches will be dropped. If you do not need them, just do not enable in your 
.config 
 
Jay 
Comment 2 Brandon Low (RETIRED) gentoo-dev 2003-03-21 15:15:19 UTC
NO.  They MUST only be patched if USE="crypt", because of legal issues involved in the cryptography patches.  Users MAY or MAY NOT be breaking import export laws governing cryptography by enabling USE="crypt" or something.  That is why it must NOT be a default patch.
Comment 3 Brandon Low (RETIRED) gentoo-dev 2003-03-21 15:15:40 UTC
Unless I'm horribly mistaken about something.
Comment 4 Paul Belt 2003-03-21 15:38:05 UTC
I think what pfiefer was reffering to was if you drop usagi, the iptables patches won't apply cleanly.

It will be more work to maintain 2 patch-sets for iptables (etc), one for use with USE='crypt' and one for use with USE='-crypt'

Is that too much work to ask?  I can understand if ye say yes, but it would, IMHO, be better than dropping iptables entirely.
Comment 5 Jay Pfeifer (RETIRED) gentoo-dev 2003-03-21 15:44:46 UTC
the dropping of crypt patches has been re-added until i can get further clarification. so, the  
missing iptables patches will have to be until i get everything put together. 
 
and yes Paul, you are correct. 
  
Jay  
Comment 6 Jay Pfeifer (RETIRED) gentoo-dev 2003-03-21 21:08:47 UTC
just a note on breaking crypto laws: 
 
dropping the patches or keeping the patches is irrelevant at the point where the ebuild drops 
the patches. since the end-user has already downloaded the code and has it on his or her pc. 
the source file they downloaded still contains the crypto code regardless of whether we drop 
it. 
 
more on this later. 
Comment 7 Paul Belt 2003-03-22 02:33:17 UTC
if [ -z "`use crypt`" ]; then
   SRC_URI="http://www.kernel.org/pub/linux/kernel/v2.4/linux-${OKV}.tar.bz2
   mirror://gentoo/patches-nocrypt-${KV}.tar.bz2"
else
   SRC_URI="http://www.kernel.org/pub/linux/kernel/v2.4/linux-${OKV}.tar.bz2
   mirror://gentoo/patches-crypt-${KV}.tar.bz2"
fi
Comment 8 Brandon Low (RETIRED) gentoo-dev 2003-03-22 02:44:24 UTC
NO.

can't use bash ifs in any of the ebuild variable definitions.

we could do it with portage ifs, but that would require maintaining two separate patchsets... I leave whether he wants to do that up to pfeifer.