Bug 179257 – media-video/mplayer-1.0.20070622: ${D}/Gui -> ${S}/gui

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2007-05-20 19:43:15 UTC]

* Make install completed
cp: nie można wykonać stat na `/var/tmp/portage/media-video/mplayer-1.0.20070427/work/mplayer-20070427/Gui/mplayer/pixmaps/logo.xpm': Nie ma takiego pliku ani katalogu
>>> Completed installing mplayer-1.0.20070427 into /var/tmp/portage/media-video/mplayer-1.0.20070427/image/


In mplayer-1.0.20070427.ebuild in line 493:
  newins ${S}/Gui/mplayer/pixmaps/logo.xpm mplayer.xpm

This should be changed to:
  newins ${S}/gui/mplayer/pixmaps/logo.xpm mplayer.xpm

[Comment 1 Steve Dibb (RETIRED) 2007-05-20 22:47:09 UTC]

fixed in cvs, thanks

[Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2007-05-22 06:59:02 UTC]

(In reply to comment #1)
> fixed in cvs, thanks

It should be ${S}/gui not ${D}/Gui (http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/mplayer/mplayer-1.0.20070427.ebuild?r1=1.1&r2=1.2).

[Comment 3 Steve Dibb (RETIRED) 2007-05-22 13:07:32 UTC]

No, it should be ${D}.  But why the lowercase gui?

[Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2007-05-24 13:29:11 UTC]

(In reply to comment #3)
> No, it should be ${D}.

Sources are unpacked to ${WORKDIR} = ${PORTAGE_TMPDIR}/portage/${CATEGORY}/${PF}/work = ${PORTAGE_TMPDIR}/portage/media-video/mplayer-1.0.20070427/work (${PORTAGE_TMPDIR} is normally /var/tmp).

In mplayer-1.0.20070427.ebuild there is S="${WORKDIR}/${PN}-${MY_PV}".

D is the path to the temporary install directory (${D} = ${PORTAGE_TMPDIR}/portage/${CATEGORY}/${PF}/image = ${PORTAGE_TMPDIR}/portage/media-video/mplayer-1.0.20070427/image).

In src_install() there is:
 make prefix=${D}/usr \
		 BINDIR=${D}/usr/bin \
		 LIBDIR=${D}/usr/$(get_libdir) \
		 CONFDIR=${D}/etc/mplayer \
		 DATADIR=${D}/usr/share/mplayer \
		 MANDIR=${D}/usr/share/man \
		 install || die "Failed to install MPlayer!"

After src_install() the content of ${D} is copied to ${ROOT} (Defaultly "/"). I hope that you don't expect that MPlayer would install /Gui/mplayer/pixmaps/logo.xpm. It would be conflicting with Filesystem Hierarchy Standard. See http://www.pathname.com/fhs/ and http://www.pathname.com/fhs/pub/fhs-2.3.html.

(In reply to comment #3)
> But why the lowercase gui?

As you can see in MPlayer repository (http://svn.mplayerhq.hu/mplayer/trunk/gui/), directory "Gui" was renamed to "gui" about 4 weeks ago.

[Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2007-06-19 10:47:11 UTC]

Somebody change the following line:
newins ${D}/Gui/mplayer/pixmaps/logo.xpm mplayer.xpm

To:
newins ${S}/gui/mplayer/pixmaps/logo.xpm mplayer.xpm

[Comment 6 Steve Dibb (RETIRED) 2007-06-22 20:17:49 UTC]

(In reply to comment #5)
> Somebody change the following line:
> newins ${D}/Gui/mplayer/pixmaps/logo.xpm mplayer.xpm
> 
> To:
> newins ${S}/gui/mplayer/pixmaps/logo.xpm mplayer.xpm
> 

http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1

[Comment 7 Reimar Döffinger 2007-06-23 08:59:33 UTC]

As an outsider I have to say I really don't get what your reference to the handbook is supposed to help.
There is no and should not be a file in /usr/Gui/mplayer/pixmaps/logo.xpm, so why should that ${D}/Gui/mplayer/pixmaps/logo.xpm make even remotely sense???

[Comment 8 Piotr Jaroszyński (RETIRED) 2007-06-23 10:29:50 UTC]

Steve, just fix it please.

[Comment 9 Samuli Suominen (RETIRED) 2007-06-24 17:00:00 UTC]

I don't know how that link is supposed to fix it but Makefile shipped with mplayer allready installs both mplayer.xpm and mplayer.desktop to correct locations so I've simply removed these lines from mplayer-1.0.20070622.ebuild:

insinto /usr/share/pixmaps
newins ${D}/Gui/mplayer/pixmaps/logo.xpm mplayer.xpm
insinto /usr/share/applications
doins ${FILESDIR}/mplayer.desktop

And if that wasn't the case they should have been replaced by "doicon" and "domenu" functions..