Bug 178580 – Add pax-mark to media-video/mplayer-1.0.20070427

• Status: RESOLVED INVALID
• Product: Gentoo Linux

[Description Christian Heim (RETIRED) 2007-05-14 22:20:16 UTC]

Currently, I have to paxctl -m it myself, but as we happen to have a pax-utils eclass in the tree, why should we use that ?

$ cvs diff mplayer-1.0.20070427.ebuild 
Index: mplayer-1.0.20070427.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/media-video/mplayer/mplayer-1.0.20070427.ebuild,v
retrieving revision 1.1
diff -u -b -B -r1.1 mplayer-1.0.20070427.ebuild
--- mplayer-1.0.20070427.ebuild 27 Apr 2007 21:46:16 -0000      1.1
+++ mplayer-1.0.20070427.ebuild 14 May 2007 22:04:46 -0000
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/media-video/mplayer/mplayer-1.0.20070427.ebuild,v 1.1 2007/04/27 21:46:16 beandog Exp $
 
-inherit eutils flag-o-matic multilib
+inherit eutils flag-o-matic multilib pax-utils
 
 RESTRICT="nostrip"
 IUSE="3dnow 3dnowext a52 aac aalib alsa altivec amr arts bidi bl bindist cddb
@@ -480,6 +480,9 @@
        find "${S}/TOOLS" -type f | xargs -- chmod 0644
        cp -r "${S}/TOOLS" "${D}/usr/share/doc/${PF}/" || die
 
+       # provide MPROTECT markings
+       pax-mark -m "${D}"/usr/bin/mplayer
+
        # Install the default Skin and Gnome menu entry
        if use gtk; then
                dodir /usr/share/mplayer/skins

[Comment 1 solar (RETIRED) 2007-05-14 23:09:08 UTC]

phreak what USE= flags do you have enabled? -m should only be needed when 
textrels happen and or using win32codecs or playing some .avi formats.

[Comment 2 Christian Heim (RETIRED) 2007-05-15 10:52:45 UTC]

(In reply to comment #1)
> phreak what USE= flags do you have enabled? -m should only be needed when 
> textrels happen and or using win32codecs or playing some .avi formats.

My USE for mplayer looks like this:

media-video/mplayer-1.0.20070427  USE="X a52 aac alsa custom-cflags dts dvd dvdread mad mp2 mp3 opengl rtc truetype vorbis win32codecs xinerama xv xvid"

Yeah, this only happens when playing Xvid (as far as I know), so the textrels might be due to libxvid.so.4 having those ..

[Comment 3 Christian Heim (RETIRED) 2007-05-15 15:27:52 UTC]

(In reply to comment #1)
> phreak what USE= flags do you have enabled? -m should only be needed when 
> textrels happen and or using win32codecs or playing some .avi formats.

Yessir, you're right as usual .. it's due to the textrels in media-libs/xvid (bug 135326); once they are gone (thanks to pipacs textrel patch), I can play those movies without any problems ..

[Comment 4 Reimar Döffinger 2007-05-16 14:24:23 UTC]

Why are you using xvid for playback anyway? I am not currently aware of advantages over the default ffmpeg decoder.