Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 178173 - net-dialup/slmodem-2.9.11_pre20070505 version bump plus multiple fixes
Summary: net-dialup/slmodem-2.9.11_pre20070505 version bump plus multiple fixes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 178030
  Show dependency tree
 
Reported: 2007-05-12 11:16 UTC by Jakub Moc (RETIRED)
Modified: 2007-05-16 10:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
slmodem-2.9.11_pre20070505.ebuild.diff (slmodem-2.9.11_pre20070505.ebuild.diff,3.31 KB, patch)
2007-05-15 19:14 UTC, Jakub Moc (RETIRED)
Details | Diff
slmodem-2.9.11_pre20070505.ebuild.diff (slmodem-2.9.11_pre20070505.ebuild.diff,4.53 KB, patch)
2007-05-15 20:13 UTC, Jakub Moc (RETIRED)
Details | Diff
slmodem-2.9.11_pre20070505.ebuild.diff (slmodem-2.9.11_pre20070505.ebuild.diff,4.56 KB, patch)
2007-05-15 20:32 UTC, Jakub Moc (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Moc (RETIRED) gentoo-dev 2007-05-12 11:16:57 UTC
- the ebuild tries to install non-existant devfsd rules (and remove them in pkg_preinst)

<snip>
# Add configuration for devfs, udev
insinto /etc/devfs.d/; newins "${FILESDIR}/${PN}-2.9.devfs" ${PN}

...

# Remove obsolete devfs configuration files if the box use udev
if [ -e "${ROOT}/dev/.udev" ]; then
        rm -r "${D}/etc/devfs.d"
fi
</snip>

- the ebuild installs blacklist entry that has no chance of working anywhere. udev doesn't honor /etc/hotplug/blacklist.d/ stuff, only /etc/modprobe.d/blacklist

- the ebuild has some info on the ungrab-winmodem issue, however adding something like this (commented out) to /etc/modules.d/slmodem would be way more easy for users...

<snip>
install slamr modprobe --ignore-install ungrab-winmodem ; sleep 5 ; modprobe --ignore-install slamr
install slusb modprobe --ignore-install ungrab-winmodem ; sleep 5 ; modprobe --ignore-install slusb
</snip>
Comment 1 Alin Năstac (RETIRED) gentoo-dev 2007-05-15 16:19:50 UTC
(In reply to comment #0)
> - the ebuild tries to install non-existant devfsd rules (and remove them in
> pkg_preinst)

I cannot use $ROOT in src_*, therefore I have remove devfsd files in pkg_postinst.

> - the ebuild installs blacklist entry that has no chance of working anywhere.
> udev doesn't honor /etc/hotplug/blacklist.d/ stuff, only
> /etc/modprobe.d/blacklist

Please elaborate. Currently we don't have a /etc/modprobe.d/, so I'm a little confused what you want me to do.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-05-15 16:32:52 UTC
(In reply to comment #1)
> I cannot use $ROOT in src_*, therefore I have remove devfsd files in
> pkg_postinst.

Well, the file in doins doesn't exist in the first place, so the thing was pretty pointless :)

> > - the ebuild installs blacklist entry that has no chance of working anywhere.
> > udev doesn't honor /etc/hotplug/blacklist.d/ stuff, only
> > /etc/modprobe.d/blacklist

# equery f sys-fs/udev | grep modprobe.d
/etc/modprobe.d
/etc/modprobe.d/blacklist
/etc/modprobe.d/pnp-aliases

Anyway, to your question: udev now has a wrapper to get blacklisting working again (see Bug 130766) - but it needs to find the stuff in /etc/modprobe.conf; it will be added there when you run /sbin/update-modules. See /sbin/update-modules for a list of honored locations, /etc/hotplug/blacklist.d/ is not among them, so anything you stick there is useless. 

Basically, something like this will do the job:

-dodir /etc/hotplug/blacklist.d	
-echo -e "slusb\nslamr\nsnd-intel8x0m" >> "${D}/etc/hotplug/blacklist.d/${PN}"
+dodir /etc/modprobe.d
+echo -e "slusb\nslamr\nsnd-intel8x0m" >> "${D}/etc/modprobe.d/${PN}-blacklist"
Comment 3 Alin Năstac (RETIRED) gentoo-dev 2007-05-15 16:57:34 UTC
(In reply to comment #2)
> Well, the file in doins doesn't exist in the first place, so the thing was
> pretty pointless :)

Not for the lads that still use devfsd or the ones that use the generated binpkg on mixed systems (devfs/udev).

Anyway, if you decide to become the maintainer, please note there is a new upstream version ready to be added to the tree.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2007-05-15 17:04:42 UTC
(In reply to comment #3)
> Not for the lads that still use devfsd or the ones that use the generated
> binpkg on mixed systems (devfs/udev).

Uh, I'll try to be more clear:

newins "${FILESDIR}/${PN}-2.9.devfs" ${PN}

$ ls -1 /usr/portage/net-dialup/slmodem/files/
slmodem-2.9.11-kernel-2.6.19.patch
slmodem-2.9.11-makefile.patch
slmodem-confd
slmodem-initd
slmodem-modules
slusb.hotplug

Can't doins non-existant file. :)

> Anyway, if you decide to become the maintainer, please note there is a new
> upstream version ready to be added to the tree.

Meh, I'm not an ebuild dev. Anyway, feel free to CC me on the bugs (or I'll CC myself), I can do some testing for this. :)
Comment 5 Alin Năstac (RETIRED) gentoo-dev 2007-05-15 17:14:34 UTC
Ups... devfs support should be removed from the ebuild then.

Please make an ebuild for the latest packages (slmodem and ungrab-winmodem) found in http://linmodems.technion.ac.il/packages/smartlink/ and I'll commit it.
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2007-05-15 17:30:20 UTC
(In reply to comment #5)
> Please make an ebuild for the latest packages (slmodem and ungrab-winmodem)
> found in http://linmodems.technion.ac.il/packages/smartlink/ and I'll commit
> it.

Well, I'll test w/ the latest slmodem snapshot; not really sure about the ungrab-winmodem update, I've been looking at the various snapshots and they seem to just pretty much randomly remove/add devices there. *confused*
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2007-05-15 19:14:19 UTC
Created attachment 119385 [details, diff]
slmodem-2.9.11_pre20070505.ebuild.diff

OK, I've committed this into sunrise for review; adding a diff against current ebuild here; please comment/ask if you have questions. Still using the old ungrab-winmodem tarball, I'll compare the various snapshots and try to figure out something.

http://overlays.gentoo.org/svn/proj/sunrise/portage-review/net-dialup/slmodem/
Comment 8 Jakub Moc (RETIRED) gentoo-dev 2007-05-15 20:13:28 UTC
Created attachment 119387 [details, diff]
slmodem-2.9.11_pre20070505.ebuild.diff

OK, finished. Uptodate version in sunrise, incl. all stuff needed in ${FILESDIR} and diff attached. Tested on x86 w/ 2.6.21 kernel.
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2007-05-15 20:32:57 UTC
Created attachment 119392 [details, diff]
slmodem-2.9.11_pre20070505.ebuild.diff

Bleh, attached wrong diff (broken blacklist).
Comment 10 Jakub Moc (RETIRED) gentoo-dev 2007-05-16 09:55:27 UTC
So... Nuked udevtrigger from postinst, and using /$(get_libdir)/udev now as udev/amd64 folks want to change the stuff in the tree to use that. No more changes  planned, so just grab the uptodate stuff from sunrise and commit.

Thanks!
Comment 11 Alin Năstac (RETIRED) gentoo-dev 2007-05-16 10:46:20 UTC
slmodem-2.9.11_pre20070505 is now in the tree.

Good job!