Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 17801 - makewhatis in sys-apps/man bug
Summary: makewhatis in sys-apps/man bug
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Martin Holzer (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-19 00:50 UTC by Paul Thompson
Modified: 2003-03-20 01:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
makewhatis patch (makewhatis.patch,360 bytes, patch)
2003-03-19 00:51 UTC, Paul Thompson
Details | Diff
larger patch to makewhatis (makewhatis.patch,501 bytes, patch)
2003-03-20 01:05 UTC, Paul Thompson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Thompson 2003-03-19 00:50:09 UTC
This semi-colon should be a colon, I guess. Recent man ebuild emerge
started causing cron barf. Looks like an obvious typo; havent evaluated
the program logic at all. Probably should be pushed upstream:
Patch also attached;
Paul

--- makewhatis.orig.1   2003-03-19 00:43:45.000000000 -0500
+++ makewhatis  2003-03-19 00:41:41.000000000 -0500
@@ -55,7 +55,7 @@
        if [ x$dc = x ]; then dc=$d; else dc=$dc:$d; fi
     fi
 done
-DEFCATPATH=$dc;$DEFMANPATH
+DEFCATPATH=$dc:$DEFMANPATH
 
 # In case /usr is read-only, make /usr/man/whatis (etc) a symlink to
 # something like /var/cache/man/whatis.
Comment 1 Paul Thompson 2003-03-19 00:51:20 UTC
Created attachment 9586 [details, diff]
makewhatis patch
Comment 2 Matthew Humphrey 2003-03-19 07:14:58 UTC
Changing the semi-colon to a colon does indeed fix the bug.
Comment 3 Martin Holzer (RETIRED) gentoo-dev 2003-03-19 17:24:44 UTC
fixed with man-1.5l-r1

thx
Comment 4 Paul Thompson 2003-03-20 01:03:53 UTC
Hi;

I find I need this patch to make the -s option work. Probably Im the only
one is in the world that uses it:) eg.

/usr/sbin/makewhatis -u -s "1 2 4 5 6 7" /usr/X11R6/man

(I cut out section 3, because its too full of tons of perl/tk/X,
etc. crap)

--- makewhatis.orig.1   2003-03-19 00:43:45.000000000 -0500
+++ makewhatis  2003-03-20 00:49:47.000000000 -0500

@@ -92,7 +92,7 @@
 
 sections="1 2 3 4 5 6 7 8 9 n l"
 
-for name in $*
+for name in "$@"
 do
 if [ -n "$setsections" ]; then
        setsections=

Without this change, the arg parsing thinks you only want section 1,
then interprets the '2' as a manpath to check, and craps out. In
other words, "1 2 4 5 6 7" doesnt get parsed as a single argument to
-s, but as a bunch of separate arguments.

Paul
Comment 5 Paul Thompson 2003-03-20 01:05:47 UTC
Created attachment 9627 [details, diff]
larger patch to makewhatis

This combines the first patch with my new one. It seems to work here,
and allows -s option, but obviously it should be verified...