Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 177778 - Undocumented ESVN variables.
Summary: Undocumented ESVN variables.
Status: RESOLVED WONTFIX
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Quality Assurance Team
URL: http://devmanual.gentoo.org/eclass-re...
Whiteboard:
Keywords:
Depends on: 202656
Blocks:
  Show dependency tree
 
Reported: 2007-05-09 11:44 UTC by Jaak Ristioja
Modified: 2008-03-26 23:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jaak Ristioja 2007-05-09 11:44:07 UTC
The variables like ESVN_WC_REVISION and ESVN_WC_URL are undocumented in the devmanual.
Comment 1 Mark Loeser (RETIRED) gentoo-dev 2007-12-16 19:05:39 UTC
(In reply to comment #0)
> The variables like ESVN_WC_REVISION and ESVN_WC_URL are undocumented in the
> devmanual.
> 

I can't find any mention of ESVN_WC_REVISION in the eclass, and ESVN_WC_URL isn't really documented.

hattya, could you let us know if ESVN_WC_URL should be something set in an ebuild, and why one would set it?  I can only find one ebuild in the tree that mentions that variable.
Comment 2 Mark Loeser (RETIRED) gentoo-dev 2007-12-16 19:08:01 UTC
(In reply to comment #1)
> I can't find any mention of ESVN_WC_REVISION in the eclass, and ESVN_WC_URL
> isn't really documented.

I take this back.  I see where it is created, but still doesn't tell me how it is intended to be used.
Comment 3 Jaak Ristioja 2007-12-16 21:12:55 UTC
(In reply to comment #1)
> hattya, could you let us know if ESVN_WC_URL should be something set in an
> ebuild, and why one would set it?  I can only find one ebuild in the tree that
> mentions that variable.

Consider one (a developer, a tester or a bleeding edge maniac) having a problem with a development program emerged from SVN. How would one know what SVN revision of that package one is using and/or had installed?

For example, using the following code in the ebuild would at least leave a trace in the log files:

pkg_postinst() {
        einfo "Emerged Program from SVN (${ESVN_WC_URL}) revision ${ESVN_WC_REVISION}."
}

This might avoid some complications when developers ask one to state the SVN revision they were using when an issue occured.
Comment 4 Bo Ørsted Andresen (RETIRED) gentoo-dev 2008-02-21 13:42:47 UTC
The eclass has a man page now if you install eclass-manpages.
Comment 5 Jaak Ristioja 2008-03-14 19:31:31 UTC
(In reply to comment #4)
> The eclass has a man page now if you install eclass-manpages.

Yes, however
1) eclass-manpages is blocked by portage-manpages (which should be a more complete set of man pages?)
2) eclass-manpages has a file collision:
    * app-admin/webapp-config-1.50.16-r1
    *      /usr/share/man/man5/webapp.eclass.5.bz2

I'd also recommend to explicitly write out the meanings of those variables on the subversion.eclass manpage for extra clarity.

PS: Before you told me, I didn't even know these man pages existed. Using Google, I found no references to them in the online Gentoo Development docs. Nor did I find there any reference to the DevManual. So in case my Google'ing skills didn't fail me today and Google is inerrant, this might be something to think about.
Comment 6 Bo Ørsted Andresen (RETIRED) gentoo-dev 2008-03-14 19:51:20 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > The eclass has a man page now if you install eclass-manpages.
> 
> Yes, however
> 1) eclass-manpages is blocked by portage-manpages (which should be a more
> complete set of man pages?)

portage-manpages is deprecated in favour of eclass-manpages. If it contains useful docs that eclass-manpages doesn't then that should be added to eclass-manpages at some point...

> 2) eclass-manpages has a file collision:
>     * app-admin/webapp-config-1.50.16-r1
>     *      /usr/share/man/man5/webapp.eclass.5.bz2

File a separate bug for that please.

> I'd also recommend to explicitly write out the meanings of those variables on
> the subversion.eclass manpage for extra clarity.

I don't follow. What's missing?

> PS: Before you told me, I didn't even know these man pages existed. Using
> Google, I found no references to them in the online Gentoo Development docs.
> Nor did I find there any reference to the DevManual. So in case my Google'ing
> skills didn't fail me today and Google is inerrant, this might be something 
> to think about.

Sure. It's still a work in progess but it should become documented somewhere...
Comment 7 Jaak Ristioja 2008-03-14 20:20:52 UTC
> > 2) eclass-manpages has a file collision:
> >     * app-admin/webapp-config-1.50.16-r1
> >     *      /usr/share/man/man5/webapp.eclass.5.bz2
> 
> File a separate bug for that please.
Here you go: bug 213436

> > I'd also recommend to explicitly write out the meanings of those variables on
> > the subversion.eclass manpage for extra clarity.
> 
> I don't follow. What's missing?
Sorry, forgot to say: I didn't have time to read through the whole manpage, but I specifically meant the ESVN_WC_* variables returned by the subversion_wc_info function. Well, ESVN_WC_URL and ESVN_WC_REVISION should be self-explanatory to everyone using version control, but ESVN_WC_UUID, ESVN_WC_ROOT and ESVN_WC_PATH for example might not.
Comment 8 Mark Loeser (RETIRED) gentoo-dev 2008-03-26 23:56:55 UTC
This will be fixed as soon as we have the eclasses automatically generate into devmanual's markup, which is bug #202656