Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 177595 - fowners and fperms descriptions look wrong (patch)
Summary: fowners and fperms descriptions look wrong (patch)
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All All
: High normal
Assignee: Gentoo Quality Assurance Team
URL: http://devmanual.gentoo.org/function-...
Whiteboard:
Keywords:
: 197984 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-05-08 08:30 UTC by Denis Dupeyron (RETIRED)
Modified: 2007-12-16 19:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fowners-fperms.patch (fowners-fperms.patch,810 bytes, patch)
2007-05-08 08:31 UTC, Denis Dupeyron (RETIRED)
Details | Diff
vapier's suggestion (bug177595.patch,738 bytes, patch)
2007-12-16 19:22 UTC, Mark Loeser (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Dupeyron (RETIRED) gentoo-dev 2007-05-08 08:30:22 UTC
Here's the current description for fowners and fperms:

fowners: Call chown with the first argument as the mode on all additional arguments.
fperms: Call chown with the first argument as the user on all additional arguments.

I think it should be:

fowners: Call chown with the first argument as the user on all additional arguments.
fperms: Call chmod with the first argument as the mode on all additional arguments.

Patch below.
Denis.
Comment 1 Denis Dupeyron (RETIRED) gentoo-dev 2007-05-08 08:31:10 UTC
Created attachment 118528 [details, diff]
fowners-fperms.patch
Comment 2 SpanKY gentoo-dev 2007-05-08 19:00:05 UTC
both are incorrect as both imply limitations on the scripts which do not exist

fowners runs chown on the specified files in $D
fperms runs chmod on the specified files in $D

there is no requirement anymore that the first argument be user/mode ... think usage of things like -R for recursive ...
Comment 3 Denis Dupeyron (RETIRED) gentoo-dev 2007-05-08 21:02:35 UTC
(In reply to comment #2)
> both are incorrect as both imply limitations on the scripts which do not exist
[...]
> there is no requirement anymore that the first argument be user/mode ... think
> usage of things like -R for recursive ...

I just checked and, well, you're right as always. Anyway, I only wanted to flag that those descriptions were wrong and I hate opening a bug without submitting a patch.

Denis.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2007-11-03 22:10:09 UTC
*** Bug 197984 has been marked as a duplicate of this bug. ***
Comment 5 Mark Loeser (RETIRED) gentoo-dev 2007-12-16 19:22:32 UTC
Created attachment 138647 [details, diff]
vapier's suggestion

This is what is applied now.  Basically what vapier suggested
Comment 6 Mark Loeser (RETIRED) gentoo-dev 2007-12-16 19:23:09 UTC
Reopen if you don't like the new description