Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 17759 - bootsplash minor correction in local.start
Summary: bootsplash minor correction in local.start
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High minor (vote)
Assignee: Troy Dack
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-18 11:49 UTC by Arun Bhanu (RETIRED)
Modified: 2003-04-10 18:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
local.start.patch (local.start.patch,442 bytes, patch)
2003-03-18 11:52 UTC, Arun Bhanu (RETIRED)
Details | Diff
bootsplash-0.4.ebuild.diff (bootsplash-0.4.ebuild.diff,3.33 KB, patch)
2003-03-18 21:17 UTC, Troy Dack
Details | Diff
/etc/init.d/bootsplash (bootsplash,879 bytes, text/plain)
2003-03-18 21:20 UTC, Troy Dack
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arun Bhanu (RETIRED) gentoo-dev 2003-03-18 11:49:41 UTC
line 15 of local.start in bootsplash contains the following line:
do /usr/bin/splash -s -u $TTY /usr/share/bootsplash-PV/gentoo-console-
1280x1024.cfg; \

I think it should read bootsplash.cfg instead of gentoo-console-1280x1024.cfg. 
bootsplash.cfg is a symbolic link to which ever configuration file that you 
want to use. So every time we use a different cfg file we only have update the 
symbolic link. We don't have to make changes to local.start file.

local.stop file does this correctly.

I've attached a simple patch that fixes this one line.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Arun Bhanu (RETIRED) gentoo-dev 2003-03-18 11:52:35 UTC
Created attachment 9565 [details, diff]
local.start.patch

this one line patch should fix the problem
Comment 2 Seemant Kulleen (RETIRED) gentoo-dev 2003-03-18 19:43:19 UTC
actually, I am going to release a -r1 for bootsplash with its own initscripts.  it should not use local
Comment 3 Troy Dack 2003-03-18 21:17:21 UTC
Created attachment 9582 [details, diff]
bootsplash-0.4.ebuild.diff

Patch against bootsplash-0.4.ebuild to include rc script for bootsplash and to
install bootsplash into /usr/share/${PN} instead of /usr/share/${P}
Comment 4 Troy Dack 2003-03-18 21:20:06 UTC
Created attachment 9583 [details]
/etc/init.d/bootsplash

/etc/init.d rc script for bootsplash - to be plased in ${FILESDIR}.

Please test this and the preceeding patch.

Note: I have not tested these as they were produced under Cygwin with the aid
of my very unreliable memory and the very reliable Gentoo docs :)
Comment 5 Troy Dack 2003-03-18 21:31:37 UTC
For information:
   The rc script will leave the VT's looking a little "untidy", especially if you are using something like linux_logo to create a fancy /etc/issue.

This can be fixed by doing a "killall agetty" (probably a SIGHUP to each agetty will do) after changing the frame buffer image.

Since the agetty's are all listed in /etc/inittab with respawn then they simply restart and re-display /etc/issue, taking into account the changed terminal size (columns & rows)

From memory the killall will respond with something about no processes being killed, then the /etc/issue contents is displayed.
Comment 6 Troy Dack 2003-03-19 08:56:03 UTC
OK,  
	New and improved 0.4-r1 ebuild commited. 
 
Now has /etc/init.d/bootsplash rc script, no more hacking 
/etc/conf.d/local.{start,stop} 
 
Arun, in regard to your initial comment: 
	There are two lots of config files and images. One is for the actual 
startup/shutdown of Gentoo, while all the Starting ..... [ OK ] messages are 
displayed. (the bootsplash.{cfg,jpg} symlinks) 
 
The second set of images are for the consoles when they are in normal use. 
(the consolesplash.{cfg,jpg} symlinks) 
 
The initrd is created using the bootsplash.* symlinks. 
 
Please test and let me know how it goes. 
Comment 7 Arun Bhanu (RETIRED) gentoo-dev 2003-03-22 16:25:47 UTC
I like your idea of having two symbolic links consolesplash & bootsplash.

okay, i've tested the bootsplash-0.4-r1 with gentoo-sources-2.4.20-r2. Everything is working fine except for a very trivial problem. 

Couple of things I would like to clarify:
I had to manually delete the entries in local.start & local.stop. Is there a way we could provide ._cfg in diff format so that users upgrading from 0.4 to 0.4-r1 can do a etc-update and doesn't have to manually update those files. Just an idea. I don't know whether it is difficult to achieve. 

There is minor problem though. If you use two cfg files - one for bootsplash and one for consolesplash with different values for tw then I encounter the follwing behaviour. bootsplash.cfg contains tw=780 and consolesplash contains tw=1008. When I reboot, I get the messages like
* Setting Console frame buffer images
[ok]
* Setting local
[ok]
All other messages after that align properly. Notice that [ok] is in the next line.
But if both cfg files contain the same tw then when you reboot I get all the messages get aligned properly.
* Setting Console frame buffer images               [ok]
* Setting local                                     [ok]
other messages...

Can anyone else reproduce this or is it just me?
Comment 8 Troy Dack 2003-04-10 18:49:06 UTC
Arun,
     bootsplash has now made it to 0.5. A -r1 will be out shortly to address a couple of minor problems that 0.5 has.

I'm not sure if it is possible to provide a ._cfg diff, I'll see what I can do.

Regarding the formatting of the [ OK ] messages, I don't think there is a lot too be done there.  The rc scripts caclulate the terminal width before the width of the terminal is changed by changing the console image. This is why the bootsplash message is formatted incorrectly and all the other messages come of properly.