Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 17739 - added checks for repoman ?
Summary: added checks for repoman ?
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: High normal
Assignee: Nicholas Jones (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-17 23:25 UTC by Mark Guertin
Modified: 2011-10-30 22:38 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
repoman patch for IUSE, aux_get, KEYWORDS, LICENSE (repoman.diff,5.95 KB, text/plain)
2003-03-18 06:30 UTC, Mark Guertin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Guertin 2003-03-17 23:25:47 UTC
Heres a short list of some things that might help us if we can add to repoman,
and in theory sound pretty simple to do:

LICENSE checks:
look for valid name, valid formatting (i.e. space delimited and not | ), and
verified that the file exists in licenses/*

stable vs. unstable checks:
If a pkg is set as stable on any arch, then repoman should also do the
equivalent of emerge -ep on the pkg, if possible avoiding current portage cache
(as any ~arch pkgs installed in your current env can sway this list in theory).
 I think the default behaviour is similar for this with USE already, so maybe a
--deep would do it?  This would help to eliminate emerge -up world problems that
arise regularly.

aux_get() syntax check:
I have seen ebuilds that pass with repoman that actually had syntax errors, etc
that failed immediately on aux_get() calls.  Can a fake aux_get() be run with
repoman to help flush out syntax errors?

IUSE check:
Check that all of the options in IUSE= actually exist, warn if there are local
ones not yet rattified.  This should be able to check against use.desc file
directly (and if we end up with an extra one for local use the same could
apply).  Optionally if it could somehow scan for undocumented USE in the build
itself it would be ideal, but not sure if the work is worth the results on this
(it doesnt seem like a simple fix).

KEYWORDS check:
Maybe we can check against a valid list of KEYWORDS (maybe we should have a
keywords file in profiles/* ) ?  If we did we can help flush out things like
KEYWORDS="*" and help to prevent people from trying to invent new keywords that
arent rattified :)


That's about it for now, looking forward to comments on this, and any other
ideas we could put in place simply to help this out.  The more we catch before
going into the tree is the less that we have to chase down to fix after the fact.
Comment 1 Mark Guertin 2003-03-18 06:30:40 UTC
Created attachment 9557 [details]
repoman patch for IUSE, aux_get, KEYWORDS, LICENSE

Here's a quick patch that addresses most of these concerns.  I'm not super
happy with the use.local.desc, but that is still to be worked out as a whole I
suppose.  This should apply to latest repoman
Comment 2 Seemant Kulleen (RETIRED) gentoo-dev 2003-03-25 04:46:40 UTC
alain, can you have a look at this patch? it does some nice things but b0rks when checking the entire tree.
Comment 3 Nicholas Jones (RETIRED) gentoo-dev 2003-03-26 04:02:49 UTC
Already taken care of in cvs. -r11 and -r70 (testing/snapshot)... Both work.
-r70 better tahn -r11
Comment 4 Nicholas Jones (RETIRED) gentoo-dev 2003-04-28 05:43:44 UTC
In and working. portage-2.0.48_pre3