Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 177338 - spamass-milter-0.3.1-r2.ebuild: removed dependency to sendmail
Summary: spamass-milter-0.3.1-r2.ebuild: removed dependency to sendmail
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gustavo Zacarias (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-06 14:53 UTC by steveb
Modified: 2010-01-15 03:04 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mail-filter/spamass-milter/spamass-milter-0.3.1-r2.ebuild (spamass-milter-0.3.1-r2.ebuild,1.12 KB, text/plain)
2007-05-06 14:55 UTC, steveb
Details
mail-filter/spamass-milter/files/README.gentoo (README.gentoo,1.46 KB, text/plain)
2007-05-06 14:57 UTC, steveb
Details
mail-filter/spamass-milter/files/spamass-milter.conf3 (spamass-milter.conf3,767 bytes, text/plain)
2007-05-06 14:57 UTC, steveb
Details
mail-filter/spamass-milter/files/spamass-milter.rc3 (spamass-milter.rc3,926 bytes, text/plain)
2007-05-06 14:58 UTC, steveb
Details
mail-filter/spamass-milter/files/spamass-milter.conf3 (spamass-milter.conf3,788 bytes, text/plain)
2007-06-04 17:11 UTC, steveb
Details
mail-filter/spamass-milter/files/README.gentoo (README.gentoo,1.64 KB, text/plain)
2007-06-04 17:12 UTC, steveb
Details

Note You need to log in before you can comment on or make changes to this bug.
Description steveb 2007-05-06 14:53:52 UTC
Modified spamass-milter ebuild to have a dependency to libmilter instead having a dependency to Sendmail. This allows me to run spamass-milter with Postfix >=2.3.0

Reproducible: Always
Comment 1 steveb 2007-05-06 14:55:19 UTC
Created attachment 118348 [details]
mail-filter/spamass-milter/spamass-milter-0.3.1-r2.ebuild
Comment 2 steveb 2007-05-06 14:57:14 UTC
Created attachment 118350 [details]
mail-filter/spamass-milter/files/README.gentoo

Modified readme to include instructions on how to integrate spamass-milter into Postfix >= 2.3.0
Comment 3 steveb 2007-05-06 14:57:59 UTC
Created attachment 118352 [details]
mail-filter/spamass-milter/files/spamass-milter.conf3

/etc/conf.d/spamass-milter file
Comment 4 steveb 2007-05-06 14:58:41 UTC
Created attachment 118354 [details]
mail-filter/spamass-milter/files/spamass-milter.rc3

/etc/init.d/spamass-milter file
Comment 5 Philipp Riegger 2007-05-19 12:29:25 UTC
This seems to be a good idea and it is working for me.
Comment 6 steveb 2007-05-19 23:27:38 UTC
(In reply to comment #5)
> This seems to be a good idea and it is working for me.
> 
With Postfix or with Sendmail?
Comment 7 Philipp Riegger 2007-05-20 12:44:29 UTC
with postfix-2.3.8 and libmilter-8.13.7
Comment 8 steveb 2007-05-21 02:11:48 UTC
(In reply to comment #7)
> with postfix-2.3.8 and libmilter-8.13.7
> 

Cool :)

I am working here with Postfix 2.4.1 and it works without problems :)
Comment 9 Philipp Riegger 2007-05-21 11:02:01 UTC
And i have to say, i really love this. It's by far the cleanest way i ever included spamassassin in a mta.
Comment 10 Gustavo Zacarias (RETIRED) gentoo-dev 2007-05-21 12:32:26 UTC
Cut the talk, there's no need to sell the idea when i'm fine with it :-)
I'm checking with net-mail devs (since i just maintain spamass-milter) on the best approach for this, for instance if postfix can provide a libmilter replacement to make it let's say "cleaner" or more native (i'm a sendmail user btw).
Otherwise this approach is fine.
Comment 11 Jan Oravec 2007-05-27 13:26:09 UTC
(In reply to comment #10)
> I'm checking with net-mail devs (since i just maintain spamass-milter) on the
> best approach for this, for instance if postfix can provide a libmilter
> replacement to make it let's say "cleaner" or more native (i'm a sendmail user
> btw).

The best approach is to use libmilter. It makes no sense for postfix to provide own library for same protocol. Milter is protocol, not library API. Packages like spamass-milter, dk-milter, sendmail, etc just use libmilter to be able to use/provide milter protocol functionality. Postfix internally implements their own milter protocol support to avoid external dependencies.
Comment 12 steveb 2007-05-27 18:55:39 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > I'm checking with net-mail devs (since i just maintain spamass-milter) on the
> > best approach for this, for instance if postfix can provide a libmilter
> > replacement to make it let's say "cleaner" or more native (i'm a sendmail user
> > btw).
> 
> The best approach is to use libmilter. It makes no sense for postfix to provide
> own library for same protocol. Milter is protocol, not library API. Packages
> like spamass-milter, dk-milter, sendmail, etc just use libmilter to be able to
> use/provide milter protocol functionality. Postfix internally implements their
> own milter protocol support to avoid external dependencies.
> 
Postfix uses libmilter. Read here for more info: http://www.postfix.org/MILTER_README.html

And Sendmail is using libmilter as well since quite some time. So switching spamass-milter to use libmilter is the save approach for both packages.
Comment 13 Jan Oravec 2007-05-27 23:03:00 UTC
(In reply to comment #12)

> Postfix uses libmilter. Read here for more info:
> http://www.postfix.org/MILTER_README.html

No, postfix itself doesn't use libmilter, but milter-based filters like dk-milter, spamass-milter, etc. use libmilter. The README just tells how to install milters based on libmilter library.

> And Sendmail is using libmilter as well since quite some time. So switching
> spamass-milter to use libmilter is the save approach for both packages.

My understanding is that mail-mta/sendmail package contains libmilter, and there is a mail-filter/libmilter for those who don't want sendmail. So the solution is one of:

1) make spamass-milter (and other milters) depend on || (mail-mta/sendmail mail-filter/libmilter)
 - this approach is already used in amavisd-new and mimedefang packages

2) separate libmilter out of sendmail, make sendmail depend on libmilter with USE flag "milter", make all milters depend on libmilter directly
 - more elegant and modularized, but requires heavier changes

First approach is trivial change in DEPENDS for spamass-milter.
Comment 14 Gustavo Zacarias (RETIRED) gentoo-dev 2007-05-28 12:18:12 UTC
The problem with libmilter (net-mail devs can correct me if i'm wrong) is that IMHO it won't go stable soon since the sendmail and libmilter dev is MIA, so it's lagging behind.
I'm all for a solution but i'm not a member of the net-mail herd, i just maintain this and i'd want this to go stable when possible.
Comment 15 steveb 2007-05-29 15:46:53 UTC
(In reply to comment #13)
> (In reply to comment #12)
> 
> > Postfix uses libmilter. Read here for more info:
> > http://www.postfix.org/MILTER_README.html
> 
> No, postfix itself doesn't use libmilter, but milter-based filters like
> dk-milter, spamass-milter, etc. use libmilter. The README just tells how to
> install milters based on libmilter library.
> 
Right. Postfix does not need libmilter.


> > And Sendmail is using libmilter as well since quite some time. So switching
> > spamass-milter to use libmilter is the save approach for both packages.
> 
> My understanding is that mail-mta/sendmail package contains libmilter, and
> there is a mail-filter/libmilter for those who don't want sendmail. So the
> solution is one of:
> 
> 1) make spamass-milter (and other milters) depend on || (mail-mta/sendmail
> mail-filter/libmilter)
>  - this approach is already used in amavisd-new and mimedefang packages
> 
> 2) separate libmilter out of sendmail, make sendmail depend on libmilter with
> USE flag "milter", make all milters depend on libmilter directly
>  - more elegant and modularized, but requires heavier changes
> 
I like that one much more.


> First approach is trivial change in DEPENDS for spamass-milter.
> 

Comment 16 steveb 2007-05-29 15:48:26 UTC
(In reply to comment #14)
> The problem with libmilter (net-mail devs can correct me if i'm wrong) is that
> IMHO it won't go stable soon since the sendmail and libmilter dev is MIA, so
> it's lagging behind.
>
What is MIA?


> I'm all for a solution but i'm not a member of the net-mail herd, i just
> maintain this and i'd want this to go stable when possible.
> 
I think for the moment you could implement option 1 from comment #13 and later maybe switch to option 2. What do you think?
Comment 17 steveb 2007-06-04 17:11:33 UTC
Created attachment 121156 [details]
mail-filter/spamass-milter/files/spamass-milter.conf3

Corrections regarding the "-m" flag.
Comment 18 steveb 2007-06-04 17:12:32 UTC
Created attachment 121158 [details]
mail-filter/spamass-milter/files/README.gentoo

Corrections for Postfix >= 2.4.0
Comment 19 Denis Misiurca 2008-03-15 21:46:19 UTC
libmilter is stable, why not add it as dependency for libmilter? I remember it was some time ago. I do not want to use sendmail, Postfix works OK for me on Gentoo and Debian systems. I use spamass-milter with actively used Postfix on Debian and all works fine, why it should not work fine on Gentoo so that you can not fix this for almost an year?
Comment 20 Denis Misiurca 2008-03-15 21:48:51 UTC
(In reply to comment #19)
> I remember it was some time ago.

Sorry, this was for clamav. And I don't see reasons for spamass to not work if clamav works.
Comment 21 vulcan 2008-06-09 09:27:07 UTC
(In reply to comment #20)
> Sorry, this was for clamav. And I don't see reasons for spamass to not work if
> clamav works.

The Gentoo developer that this bug was assigned to retired some time ago.

http://www.gentoo.org/proj/en/devrel/roll-call/userinfo.xml?statusFilter=Retired
Comment 22 Tobias Scherbaum (RETIRED) gentoo-dev 2008-06-15 09:28:28 UTC
I added spamass-milter-0.3.1-r2 to CVS which includes these fixes. Thanks guys!
Comment 23 Benny Pedersen 2010-01-15 03:04:55 UTC
still unstable ?