Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 176877 - dev handbook's cvs section should cover keyword expansion in patches
Summary: dev handbook's cvs section should cover keyword expansion in patches
Status: RESOLVED OBSOLETE
Alias: None
Product: Documentation
Classification: Unclassified
Component: [OLD] Developer Handbook (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Gentoo Community Relations Team
URL: http://www.gentoo.org/proj/en/devrel/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-03 04:25 UTC by Andrew Ross (RETIRED)
Modified: 2016-01-28 20:27 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Ross (RETIRED) gentoo-dev 2007-05-03 04:25:47 UTC
I think it would be useful for the dev handbook's cvs section (http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=1&chap=4#doc_chap1) to include a warning about the expansion of upstream cvs keywords inside patches which are committed to cvs.

While such files are rare, they do exist (eg. http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-db/libpq/files/libpq-7.3.18-gentoo.patch), and the commit logs show I'm not the only dev to have made the mistake of adding them without the "-ko" or "-kb" argument to "cvs add" (which prevents keyword expansion from clobbering the file and causing the patch to fail).
Comment 1 Adam Feldman gentoo-dev 2016-01-28 20:27:57 UTC
Resolving as obsolete due to the fact that we no longer have to worry about the quirks of CVS and the handbook is no longer in use.