Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 176613 - net-www/mplayerplug-in : patch for epiphany support
Summary: net-www/mplayerplug-in : patch for epiphany support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-30 18:40 UTC by Denis Dupeyron (RETIRED)
Modified: 2007-05-16 22:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mplayerplug-in_epiphany.patch (mplayerplug-in_epiphany.patch,412 bytes, patch)
2007-04-30 18:41 UTC, Denis Dupeyron (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Dupeyron (RETIRED) gentoo-dev 2007-04-30 18:40:24 UTC
mplayerplug-in works nicely with epiphany, but emerging it requires having either firefox or seamonkey. It's OK if you use firefox as a backend for epiphany, but if you use xulrunner it will automatically want to emerge firefox, which is both useless and annoying. Please find a patch to fix that below (it's a one-liner).

Denis.
Comment 1 Denis Dupeyron (RETIRED) gentoo-dev 2007-04-30 18:41:45 UTC
Created attachment 117755 [details, diff]
mplayerplug-in_epiphany.patch

The patch discussed above.
Comment 2 Gergan Penkov 2007-04-30 18:52:41 UTC
you mean it should depend on xulrunner, as epiphany does not provide the needed libraries?
In fact the mplayerplug-in configure should be patched as it does not have a way to specify the gecko to be used, which could bring only problems - for example (as far as I remember it) it will test for firefox, mozilla, thunderbird and xulrunner and the first one found (from some random order) will be used for the build, which is not what one wants.
Comment 3 Denis Dupeyron (RETIRED) gentoo-dev 2007-05-01 08:49:00 UTC
(In reply to comment #2)
> you mean it should depend on xulrunner, as epiphany does not provide the
> needed libraries?

No, I just want it to not emerge firefox when epiphany is already installed. xulrunner doesn't play any role in this, except as a backend for epiphany instead of firefox. I you look at my patch, you'll see that I'm only adding epiphany to the list of supported browsers.

Denis.
Comment 4 Gergan Penkov 2007-05-01 09:30:30 UTC
Well that's the problem you don't depend on a consumer of a library, to which you are linking. 
As on what should mplayerplug-in depend when I want to emerge only galeon, or kazehakase, or liferea, which are all gecko embedders. 
On the other side kazehakase could be built either against gecko or against gtk-webcore, so if you add it for example as a dependancy of mplayerplug-in, you don't know against what it was built and the build will fail if it was build against gtk-webcore, as the gecko libraries are not installed.
Comment 5 Denis Dupeyron (RETIRED) gentoo-dev 2007-05-01 10:04:32 UTC
I suggest you open another bug for this as this is an entirely different problem. Epiphany always has gecko support, whether it comes from firefox or xulrunner. There is nothing to fix or change to the mplayerplug-in ebuild for epiphany support, except listing it as a supported browser which it already is out of the box.

Denis.
Comment 6 Joe Jezak (RETIRED) gentoo-dev 2007-05-16 22:41:04 UTC
Added to mplayerplug-in 3.40, thanks for letting me know!  As for the other gecko-embedders, unless mplayerplug-in supports it natively, I can't easily add support for exactly the reason you suggest.  So, if you want it to work properly, I guess get upstream to support those too.