Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 176491 - x11-misc/xscreensaver: incorrect dependency on libglade
Summary: x11-misc/xscreensaver: incorrect dependency on libglade
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-29 19:23 UTC by Thomas Fischer
Modified: 2007-06-10 07:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to xscreensaver-5.01-r3 ebuild to apply patch to xscreensaver sources if gnome useflag is not set (xscreensaver-ebuid-remove-gnome-dep.patch,842 bytes, patch)
2007-04-29 19:24 UTC, Thomas Fischer
Details | Diff
Patch to xscreensaver sources to remove dependency on libglade (xscreensaver-5.01-remove-gnome-dep.patch,1.72 KB, patch)
2007-04-29 19:25 UTC, Thomas Fischer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Fischer 2007-04-29 19:23:03 UTC
x11-misc/xscreensaver depends on gnome-base/libglade, which is not necessary in environments where xscreensaver-demo is not used (e.g. for KDE desktops).
It should be possible to disable xscreensaver-demo (and the libglade dependency) using the --without-gtk flag, but due to a bug in the configure script, building the software fails in this case; a bug report for this problem has been filed upstream.
To remove the libglade dependency, I suggest to add the gnome use flag to the ebuild and to apply a small patch to xscreensaver if this flag is not set.

Reproducible: Always
Comment 1 Thomas Fischer 2007-04-29 19:24:27 UTC
Created attachment 117663 [details, diff]
Patch to xscreensaver-5.01-r3 ebuild to apply patch to xscreensaver sources if gnome useflag is not set
Comment 2 Thomas Fischer 2007-04-29 19:25:07 UTC
Created attachment 117664 [details, diff]
Patch to xscreensaver sources to remove dependency on libglade
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2007-04-29 19:28:55 UTC
Xfce also uses xscreensaver-demo.. and likely everything except KDE so that would be USE="kde" where it should be optional if any.
Comment 4 Thomas Fischer 2007-04-29 19:41:53 UTC
> Xfce also uses xscreensaver-demo.. and likely everything
> except KDE so that would be USE="kde" where it should be
> optional if any.
Using flag "kde" wouldn't be appropriate. First, libglade is still a Gnome library, and second, what happens on machines having both KDE and Gnome installed (and both use flags set)?
Alternative proposal: Check for libglade in pkg_setup and if it is not installed print a big warning and disable xscreensaver-demo when compiling?
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2007-05-14 18:49:17 UTC
(In reply to comment #4)
> > Xfce also uses xscreensaver-demo.. and likely everything
> > except KDE so that would be USE="kde" where it should be
> > optional if any.
> Using flag "kde" wouldn't be appropriate. First, libglade is still a Gnome
> library, and second, what happens on machines having both KDE and Gnome
> installed (and both use flags set)?

Gnome library or not, removing xscreensaver-demo makes xscreensaver unusable
for everyone else except KDE users. Patch attached simply removes libglade and xscreensaver-demo from build while it should make it optional if any, --with/--without-glade. Actually, read below..

> Alternative proposal: Check for libglade in pkg_setup and if it is not
> installed print a big warning and disable xscreensaver-demo when compiling?
> 

Alternative proposal: Fix your patch to conditionalize also GTK+-2 with libglade since by looks of it, only thing using GTK+-2 and libglade is xscreensaver-demo
--with and --without-gtk so we can add USE="gtk" to xscreensaver ebuild.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2007-06-10 07:32:32 UTC
Upstream is not intrested of crippling xscreensaver by removing it's configuration 
frontend and neither am I specially without a patch.

http://www.jwz.org/xscreensaver/faq.html#kde