Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 176168 - sys-apps/lshw installs its own usb.ids and pci.ids
Summary: sys-apps/lshw installs its own usb.ids and pci.ids
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-26 21:44 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2007-05-05 06:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Source patch to only use system's .ids files (lshw-B.02.10-sysids.patch,1.56 KB, patch)
2007-04-27 18:56 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2007-04-26 21:44:47 UTC
As per summary, lshw instead of using the usb.ids already installed by usbutils, install its own copy of it, which is also outdated, and so does for pci.ids, but for this one the version in lshw is newer (will report a bug for pciutils about this).

As the two files can be updated through cron, it would be nice if lshw used the system-installed *.ids files instead.

HTH,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2007-04-27 18:56:55 UTC
Created attachment 117439 [details, diff]
Source patch to only use system's .ids files

After looking at the source, I can see that it actually tries to run quite a few usb.ids files, the last of which is the system's usb.ids, and so seems to be doing for pci.ids; nonetheless, by reducing the set to only the system's .ids files it should also be faster to execute.

The attached patch removes the two files from the installation, and reduces the set of used files.

As an alternative, only lshw's own copy of usb.ids and pci.ids could be removed by the list, still allowing the use of the others, or it could just be skipped during the installation, and the code not changed at all.
Comment 2 SpanKY gentoo-dev 2007-05-05 06:49:08 UTC
i'm not worried about the speed as you safe just 1 function call and 1 fopen per element removed from the list

i dont know about deleting the files ... lshw doesnt support compressed versions, so the pci.ids that comes with lshw is the only one that it'll find ... it ignores /usr/share/misc/pci.ids.gz ... that should be mentioned to the upstream author ;)

also, about the only thing you'll safe is disk space ... sometimes the id files with lshw will be newer, sometimes the ones from pciutils/usbutils will be newer