Bug 175818 – mythtv-plugins.eclass needs to work with 0.21_pre* releases

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Neale Swinnerton 2007-04-24 09:54:24 UTC]

The version_is_at_least "0.21" check in mythtv-plugins.eclass should be version_is_at_least "0.21_pre". Without this change the zoneminder plugin in always built

Patch:
diff -uw /usr/portage/eclass/mythtv-plugins.eclass.old  /usr/portage/eclass/mythtv-plugins.eclass
--- /usr/portage/eclass/mythtv-plugins.eclass.old       2007-04-24 10:52:00.000000000 +0100
+++ /usr/portage/eclass/mythtv-plugins.eclass   2007-04-24 10:52:10.000000000 +0100
@@ -32,7 +32,7 @@
                MYTHPLUGINS="${MYTHPLUGINS} mytharchive"
        fi
 
-       if version_is_at_least "0.21" ; then
+       if version_is_at_least "0.21_pre" ; then
                MYTHPLUGINS="${MYTHPLUGINS} mythzoneminder"
        fi
 }


Reproducible: Always

Steps to Reproduce:
1. emerge mythvideo
2.
3.

Actual Results:  
mythvideo and mythzoneminder plugins are built

Expected Results:  
just mythvideo built

[Comment 1 Doug Goldstein (RETIRED) 2007-04-25 00:40:39 UTC]

Known issue... This stuff is masked as completely development not release quality.

[Comment 2 Neale Swinnerton 2007-04-25 08:20:43 UTC]

There's no downside to making the change I suggested is there? It still works fine for the 0.20.* builds?

[Comment 3 Doug Goldstein (RETIRED) 2007-04-25 13:40:20 UTC]

The change is not necessarily the best change to make as version_is_at_least doesn't seem to optimal. I was looking into a different solution. The issue being that _pre isn't handled well by version_is_at_least (i.e. future _p level) will have issues.

[Comment 4 Doug Goldstein (RETIRED) 2007-05-11 13:52:58 UTC]

beandog: you were going to do some testing with this for me... Any status?

[Comment 5 Doug Goldstein (RETIRED) 2007-05-11 13:55:22 UTC]

Eh. Got another tester. Fixed.