For vmware-{workstation,server,player} and whatever that has vmware-config.pl, gtk-update-icon-cache /usr/share/icons/hicolor should be run when stuff in or below /usr/share/icons/hicolor is installed to keep /usr/share/icons/hicolor/icon-theme.cache up to date. Failing to do so inflicts a penalty on _every_ gnome program startup corresponding roughly to find /usr/share/icons/hicolor > /dev/null. Might apply to KDE programs as well.
Hi, could you please provide a little more information about the problem? Looking in vmware-config.pl, the only code that touches icons at all is below: $desticondir = get_persistent_answer( "In which directory do you want to install the mime type icons?", "ICONDIR", "dirpath", "/usr/share/icons"); undef %p; install_dir(db_get_answer('LIBDIR') . '/share/icons', $desticondir . "/hicolor", \%p); # Refresh icon cache. Some systems (Ubuntu) don't do it automatically system(internal_which('touch') . ' -m ' . shell_string('/usr/share/icons/hicolor/')); system(shell_string(internal_which('gtk-update-icon-cache')) . ' >/dev/null 2>&1'); As you can see, gtk-update-icon-cache would always be run on any changes to the hicolor directory. However, none of this code is ever run because all vmware-* packages (apart from vmware-workstation-4.5.3) patch out this function and install their own mime-types and desktop handlers. If your issue is with vmware-workstation-4.5.3, please specify this exactly. Also, if possible, please indicate exactly which files are being installed, so that we can determine if they really are being installed during the configuration stage, or during the main package installation. Thanks... 5:)
Thanks for looking into this. I was a bit too fast blaming vmware-{workstation,server}, it is only vmware-player (1.0.3.34682 at least ) that has a vmware-config.pl that installs /usr/share/pixmaps/vmware-player.png (symlink), /usr/share/icons/hicolor/48x48/apps/vmware-player.png, /usr/share/icons/hicolor/48x48/mimetypes/{application-x-vmware-snapshot.png,application-x-vmware-team.png,application-x-vmware-vmdisk.png,application-x-vmware-vmfoundry.png,application-x-vmware-vm.png,gnome-mime-application-x-vmware-snapshot.png,gnome-mime-application-x-vmware-team.png,gnome-mime-application-x-vmware-vmdisk.png,gnome-mime-application-x-vmware-vmfoundry.png,gnome-mime-application-x-vmware-vm.png}. Looking at vmware-config.pl around line 8953, createMimePackageFile() etc. indeed isn't commented out. Also, gtk-update-icon-cache does nothing when given no arguments (Gentoo's version at least), from all I can tell.
Hiya Simon, you're quite right, it appears that when vmplayer was bumped the patchsets we've been using didn't get bumped as well. We'll try and get this fixed soon, thanks for spotting it... 5:)
I was just informed that with the release of workstation 6, vmware-player 2.0 is out (and it also seems to require vmware-modules-1.0.0.16), so it might be worth doing the bump at the same time. I'll look into doing it if I get time over the weekend...
@ikelos: Any news? vmware-player is completely broken now (there's a version mismatch between vmware-modules and vmware-player, vmware-player's vmware-config.pl overwrites vm{mon,net}.ko installed by vmware-modules, etc.)
Tiziano, I've updated vmware-player to version 2 in the overlay. Is that the version you're refering to that has problems? I should also be receiving a license for vmware-workstation 6 from work next week and will be trying to get a valid working ebuild out sometime next week. Chris has always taken care of both player and workstation in the past, but it appears he's been extremely busy for the past several months. I do apologize for the delay, I'll try my best to get something sorted out by the end of the next week, with an eye to putting them in the main tree in two weeks time. That's about the best I can do without risking an even larger breakage of the vmware packages in the tree. 5:(
@ikelos: I was referring to the ebuild in the tree :-/
Ok, finally bit the bullet and version bumped this (but only to 1.0.3-r1) in the main tree. Hopefully all the necessary patches are now in place and it will work as the other -workstation/-server packages. I'm very sorry for the long delay... 5:( Player 2 will hopefully hit the tree in the next couple of weeks. If there are any problems with this version, please feel free to reopen this bug...
