Bug 175710 – [QA Notice: Package has poor programming practices] media-libs/audiofile-0.2.6-r3

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Dustin Polke 2007-04-23 15:37:35 UTC]

emerging of audiofile-0.2.6-r3 gives:


 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * printmarkers.c:47: warning: incompatible implicit declaration of built-in function 'fmod'
printmarkers.c:54: warning: incompatible implicit declaration of built-in function 'fmod'


Attached patch fixes this.

Reproducible: Always

[Comment 1 Dustin Polke 2007-04-23 15:38:46 UTC]

Created attachment 117089 [details, diff]
Patch to fix QA warning

[Comment 2 Alexis Ballier 2007-04-24 12:13:54 UTC]

thanks for the fix, but could you please also send the patch to the author(s) of the package ?
like always, if it's not a gentoo specific patch it's better to let the authors know about it and fix it for future versions

[Comment 3 Samuli Suominen (RETIRED) 2007-07-28 09:29:14 UTC]

Applied to -r3

[Comment 4 Samuli Suominen (RETIRED) 2007-07-28 09:32:43 UTC]

(In reply to comment #3)
> Applied to -r3
> 

And mailed upstream about it.