Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 175694 - app-emacs/ecmascript-mode & app-emacs/javascript-mode ebuild
Summary: app-emacs/ecmascript-mode & app-emacs/javascript-mode ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: EBUILD, REVIEWED
Depends on:
Blocks:
 
Reported: 2007-04-23 12:43 UTC by MATSUYAMA Tomohiro
Modified: 2007-05-05 18:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ecmascript-mode-1.1.ebuild (ecmascript-mode-1.1.ebuild,452 bytes, text/plain)
2007-04-23 12:44 UTC, MATSUYAMA Tomohiro
Details
50ecmascript-mode-gentoo.el (50ecmascript-mode-gentoo.el,240 bytes, text/plain)
2007-04-23 12:45 UTC, MATSUYAMA Tomohiro
Details
javascript-mode-1.12.ebuild (javascript-mode-1.12.ebuild,495 bytes, text/plain)
2007-04-23 12:47 UTC, MATSUYAMA Tomohiro
Details
50javascript-mode-gentoo.el (50javascript-mode-gentoo.el,240 bytes, text/plain)
2007-04-23 12:48 UTC, MATSUYAMA Tomohiro
Details
ecmascript-mode-1.1.ebuild (ecmascript-mode-1.1.ebuild,485 bytes, text/plain)
2007-04-26 10:35 UTC, MATSUYAMA Tomohiro
Details
javascript-mode-1.12.ebuild (javascript-mode-1.12.ebuild,528 bytes, text/plain)
2007-04-26 10:35 UTC, MATSUYAMA Tomohiro
Details
karl-javascript-mode-2.0_beta8.ebuild (karl-javascript-mode-2.0_beta8.ebuild,486 bytes, text/plain)
2007-04-26 10:36 UTC, MATSUYAMA Tomohiro
Details
50karl-javascript-mode-gentoo.el (50karl-javascript-mode-gentoo.el,240 bytes, text/plain)
2007-04-26 10:36 UTC, MATSUYAMA Tomohiro
Details
ecmascript-mode/ecmascript-mode-1.1.ebuild (ecmascript-mode-1.1.ebuild,465 bytes, text/plain)
2007-04-27 04:26 UTC, MATSUYAMA Tomohiro
Details
javascript-mode-1.12.ebuild (javascript-mode-1.12.ebuild,508 bytes, text/plain)
2007-04-27 04:27 UTC, MATSUYAMA Tomohiro
Details
karl-javascript-mode-2.0_beta8.ebuild (karl-javascript-mode-2.0_beta8.ebuild,461 bytes, text/plain)
2007-04-27 04:27 UTC, MATSUYAMA Tomohiro
Details

Note You need to log in before you can comment on or make changes to this bug.
Description MATSUYAMA Tomohiro 2007-04-23 12:43:17 UTC
Hi.

I created minimal ebuilds (app-emacs/ecmascript-mode and app-emacs/javascript-mode) for editing javascript files in emacs. They will conflict together so that emacs could decide which major-mode to load, but I don't know this is a good way...

Please tell me if there is something wrong with them because I am newbie.

Thanks.


Reproducible: Always
Comment 1 MATSUYAMA Tomohiro 2007-04-23 12:44:33 UTC
Created attachment 117076 [details]
ecmascript-mode-1.1.ebuild
Comment 2 MATSUYAMA Tomohiro 2007-04-23 12:45:03 UTC
Created attachment 117078 [details]
50ecmascript-mode-gentoo.el
Comment 3 MATSUYAMA Tomohiro 2007-04-23 12:47:39 UTC
Created attachment 117080 [details]
javascript-mode-1.12.ebuild

A version of this package is correctly 1.1-2. But a hyphen within the version is not accepted, so I omitted the hyphen...
Comment 4 MATSUYAMA Tomohiro 2007-04-23 12:48:02 UTC
Created attachment 117082 [details]
50javascript-mode-gentoo.el
Comment 5 Marijn Schouten (RETIRED) gentoo-dev 2007-04-23 12:51:02 UTC
You will need to make sure some kind of emacs is installed. Like with DEPEND="virtual/emacs" or DEPEND="app-editors/xemacs".
Comment 6 MATSUYAMA Tomohiro 2007-04-23 13:25:59 UTC
I did not write DEPEND="virtual/emacs" consciously because I found a same code in /usr/portage/eclass/elisp.class.
Comment 7 Ulrich Müller gentoo-dev 2007-04-23 13:32:15 UTC
(In reply to comment #5)
> You will need to make sure some kind of emacs is installed. Like with
> DEPEND="virtual/emacs" or DEPEND="app-editors/xemacs".

You need not; this is already set by elisp.eclass.
Comment 8 Ulrich Müller gentoo-dev 2007-04-23 13:38:28 UTC
(In reply to comment #3)
> A version of this package is correctly 1.1-2. But a hyphen within the version
> is not accepted, so I omitted the hyphen...

You should do something like the following here:

inherit versionator
MY_PV=$(replace_version_separator 2 '-')
SRC_URI="http://gentoo.panicode.com/distfiles/${PN}-${MY_PV}.tar.gz"

And the ebuild should then be named "javascript-mode-1.1.2.ebuild".
Comment 9 Ulrich Müller gentoo-dev 2007-04-23 18:56:19 UTC
(In reply to comment #8)
> > A version of this package is correctly 1.1-2. But a hyphen within the
> > version is not accepted, so I omitted the hyphen...

Sorry, I am confused. The distfile is really named 1.12, but the included elisp file has javascript-mode-version = 1.10. Which one is right?

Note that there is also javascript mode by Karl Landström. See discussion at <http://www.emacswiki.org/cgi-bin/wiki/JavaScriptMode>, especially the coloured box at the bottom.
Comment 10 MATSUYAMA Tomohiro 2007-04-24 12:04:08 UTC
> Sorry, I am confused. The distfile is really named 1.12, but the included elisp
> file has javascript-mode-version = 1.10. Which one is right?
Sorry, I confused the version about the hyphen with another version of package I created, but thanks to let me know I will fix it before posting :)
So, assuming that the author forgot to rewrite the version I decided 1.12 is right from the following link.
http://cvs.xemacs.org/viewcvs.cgi/XEmacs/packages/xemacs-packages/prog-modes/javascript-mode.el

> Note that there is also javascript mode by Karl Landström. See discussion at
> <http://www.emacswiki.org/cgi-bin/wiki/JavaScriptMode>, especially the coloured
> box at the bottom.
It seems that this javascript-mode is better than both I posted, especially about indentation.
I want to create an ebuild for new one like app-emacs/karl-javascript-mode if such the measure is usual. Or I should replace old one with new one?

Comment 11 Ulrich Müller gentoo-dev 2007-04-24 21:17:03 UTC
(In reply to comment #10)
> It seems that this javascript-mode is better than both I posted, especially
> about indentation.
> I want to create an ebuild for new one like app-emacs/karl-javascript-mode if
> such the measure is usual. Or I should replace old one with new one?

You may just post the ebuild if you wish. We can decide about the name of the package later.
Comment 12 MATSUYAMA Tomohiro 2007-04-26 10:35:16 UTC
Created attachment 117298 [details]
ecmascript-mode-1.1.ebuild
Comment 13 MATSUYAMA Tomohiro 2007-04-26 10:35:45 UTC
Created attachment 117299 [details]
javascript-mode-1.12.ebuild
Comment 14 MATSUYAMA Tomohiro 2007-04-26 10:36:25 UTC
Created attachment 117300 [details]
karl-javascript-mode-2.0_beta8.ebuild
Comment 15 MATSUYAMA Tomohiro 2007-04-26 10:36:44 UTC
Created attachment 117302 [details]
50karl-javascript-mode-gentoo.el
Comment 16 MATSUYAMA Tomohiro 2007-04-26 10:40:41 UTC
I posted karl-javascript-mode-2.0_beta8.ebuild and 50karl-javascript-mode-gentoo.el.

Please check them.
Comment 17 Ulrich Müller gentoo-dev 2007-04-26 11:14:59 UTC
(In reply to comment #16)
> I posted karl-javascript-mode-2.0_beta8.ebuild and
> 50karl-javascript-mode-gentoo.el.
> 
> Please check them.

Syntax looks O.K. (You could use ${PN} for the SITEFILE, i.e. 50${PN}-gentoo.el but this is not mandatory.)

Have you tested it on all architectures that are in KEYWORDS?
Comment 18 Christian Faulhammer (RETIRED) gentoo-dev 2007-04-26 11:17:58 UTC
(In reply to comment #16)
> Please check them.

 Thumbs up from me, too.  Same comments though.
Comment 19 MATSUYAMA Tomohiro 2007-04-26 16:40:39 UTC
> Syntax looks O.K. (You could use ${PN} for the SITEFILE, i.e. 50${PN}-gentoo.el
> but this is not mandatory.)
I will fix it.

> Have you tested it on all architectures that are in KEYWORDS?
I have tested on amd64 only...
Comment 20 Christian Faulhammer (RETIRED) gentoo-dev 2007-04-26 18:08:02 UTC
(In reply to comment #19)
> > Have you tested it on all architectures that are in KEYWORDS?
> I have tested on amd64 only...

 Then please remove all those you have not tested yourself.
Comment 21 MATSUYAMA Tomohiro 2007-04-27 04:26:51 UTC
Created attachment 117364 [details]
ecmascript-mode/ecmascript-mode-1.1.ebuild
Comment 22 MATSUYAMA Tomohiro 2007-04-27 04:27:10 UTC
Created attachment 117366 [details]
javascript-mode-1.12.ebuild
Comment 23 MATSUYAMA Tomohiro 2007-04-27 04:27:34 UTC
Created attachment 117368 [details]
karl-javascript-mode-2.0_beta8.ebuild
Comment 24 MATSUYAMA Tomohiro 2007-04-27 04:31:40 UTC
I rewrote SITEFILE with ${PN} like SITEFILE="50${PN}-gentoo.el" and removed untested keywords.
Comment 25 Ulrich Müller gentoo-dev 2007-04-27 06:44:43 UTC
Karl Landström's javascript mode is available as package app-emacs/javascript in the Emacs Overlay, see <http://overlays.gentoo.org/proj/emacs/>.
(It may take a few hours for the distfile to appear on the Gentoo mirrors.)
Comment 26 Ulrich Müller gentoo-dev 2007-05-05 18:40:00 UTC
(In reply to comment #25)
> Karl Landström's javascript mode is available as package app-emacs/javascript
> in the Emacs Overlay, see <http://overlays.gentoo.org/proj/emacs/>.

Added to CVS, thank you for submitting the ebuild.
(Keyworded as ~x86; the ~amd64 keyword will follow soon.)