Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 175525 - app-cdr/webcdwriter uses generation-1 eclasses and uses bundled jars
Summary: app-cdr/webcdwriter uses generation-1 eclasses and uses bundled jars
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Optical Media project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-22 05:50 UTC by Alistair Bush (RETIRED)
Modified: 2007-05-19 21:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
webcdwriter-2.8.0-r1.patch (webcdwriter-2.8.0-r1.patch,1.78 KB, patch)
2007-04-30 10:02 UTC, Alistair Bush (RETIRED)
Details | Diff
patch to fix configure and Makefiles.in (webcdwriter-fix-java.patch,1.98 KB, patch)
2007-04-30 10:08 UTC, Alistair Bush (RETIRED)
Details | Diff
webcdwriter-2.8.0-r1.patch (webcdwriter-2.8.0-r1.patch,1.76 KB, patch)
2007-04-30 10:10 UTC, Alistair Bush (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alistair Bush (RETIRED) gentoo-dev 2007-04-22 05:50:38 UTC
Firstly,  webcdwriter inherits java-pkg which is a Java Generation 1 eclass.  Presently the java team is pushing hard to have all packages migrated to java-pkg-2.eclass (or java-pkg-opt-2.eclass which is probably more appropriate for webcdwriter)

Secondly,  after having a look at this package I noticed that the java component is never actually built.

> * Applying configure.patch ...                                           [ ok ]
>
>Configuring webCDwriter
>
>Checking for a working javac... not found -> will use precompiled >webCDcreator.jar
>/etc/init.d... yes

after looking at the configure script I discovered that it attempts to detect javac by compiling 2 example java classes.  The is a dependency within one of these classes on javax.jnlp.ServiceManager, at it occurs multiple times within the actual source.  This should be available within the dev-java/jnlp-bin package ( I have not yet checked API compatibility )
Comment 1 Alistair Bush (RETIRED) gentoo-dev 2007-04-30 10:02:00 UTC
Created attachment 117707 [details, diff]
webcdwriter-2.8.0-r1.patch

patch to bump webcdwriter ebuild to java generation-2 eclasses.
Comment 2 Alistair Bush (RETIRED) gentoo-dev 2007-04-30 10:08:16 UTC
Created attachment 117708 [details, diff]
patch to fix configure and Makefiles.in

This patch does the following.

1) Makes the build accept JAVACFLAGS
2) Makes the build actually attempt to build the java source, instead of just using bundled jar/classes.
Comment 3 Alistair Bush (RETIRED) gentoo-dev 2007-04-30 10:10:43 UTC
Created attachment 117710 [details, diff]
webcdwriter-2.8.0-r1.patch

Just realized latest ebuild was touched while I was working on the rev bump.  This patch brings it into line with the changes that were made.  sorry for the bug spam.
Comment 4 Petteri Räty (RETIRED) gentoo-dev 2007-05-19 21:23:43 UTC
Patch committed with a a couple of improvements. Added java to metadata.xml after ack from beandog.