Bug 17526 – etc-update script missing double-quotes when checking ${pager} variable

• Status: RESOLVED FIXED
• Product: Portage Development

[Description gatto 2003-03-14 15:55:21 UTC]

On line 312 in etc-update from portage-2.0.47-r8, there is missing double quotes
surrounding the ${pager} variable. So setting pager= to something with arguments
in /etc/etc-update.conf, and running etc-update gets you the warning:
"/usr/sbin/etc-update: line 312: [: too many arguments"


Reproducible: Always
Steps to Reproduce:
1. in /etc/etc-update.conf, set pager="less -q -E"
2. run etc-update

[Comment 1 gatto 2003-03-14 15:57:27 UTC]

Created attachment 9400 [details, diff]
puts double quotes around ${pager} check in etc-update

[Comment 2 Wouter Deconinck 2003-05-13 11:42:36 UTC]

Hi, I don't have any experience with adding new bugs, so I put it here (it's only minor and in the same file) :-)

On line 368 of /usr/sbin/etc-update there is:
pager=""P

That should be:
pager=""

Now it gives problems in dialog-mode when diff'ing an interactively merged configfile with the update.

Greets,
wouter

[Comment 3 Wouter Deconinck 2003-05-13 17:12:44 UTC]

Hi,

If you remove the "P" you get a broken pipe-error.  I guess the pager was set to "" so it would not interfere with dialog.  What you get now is something like (line 305):
echo blablabla |
which of course causes a broken pipe.

greetz,
wouter

[Comment 4 Nicholas Jones (RETIRED) 2003-05-14 22:58:03 UTC]

Fxied for >=48_pre7