Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 175204 - www-servers/gorg-0.6.3 has dropped it's amd64 keyword
Summary: www-servers/gorg-0.6.3 has dropped it's amd64 keyword
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-19 12:37 UTC by Bjarke Istrup Pedersen (RETIRED)
Modified: 2007-04-23 17:17 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gorg-0.6.3-r1.patch (gorg-0.6.3-r1.patch,1.24 KB, patch)
2007-04-21 10:25 UTC, Richard Brown (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bjarke Istrup Pedersen (RETIRED) gentoo-dev 2007-04-19 12:37:12 UTC
www-servers/gorg depends on dev-db/mysql which is wrong.
It should depend on virtual/mysql, so it also works with dev-db/mysql-community.

Reproducible: Always

Steps to Reproduce:
1. Install dev-db/mysql-community
2. Set the mysql USE flag
3. Try and install www-servers/gorg

Actual Results:  
It wants to install dev-db/mysql which blocks, since dev-db/mysql and dev-db/mysql-community cannot be installed at the same time.

Expected Results:  
It should have depended on virtual/mysql, so it can work with both.
Comment 1 Mike Auty (RETIRED) gentoo-dev 2007-04-19 13:00:18 UTC
This appears to be a regression, but it's possible that there was a reason behind it.  All ebuilds below 0.6.3 feature virtual/mysql, so I've also CCed the maintainer that did the 0.6.3 bump to see if it was just an honest mistake or not...  5:)
Comment 2 Xavier Neys (RETIRED) gentoo-dev 2007-04-19 13:29:09 UTC
Just a mistake, there's no reason it could not depend on the virtual.
Please go ahead and fix the dependency.
Thanks a lot.

FYI, fixed in http://gentoo.neysx.org/mystuff/gorg/overlay.xml
Comment 3 Richard Brown (RETIRED) gentoo-dev 2007-04-19 13:49:55 UTC
Fixed in cvs.

amd64, you lost your keyword on this bump.
Comment 4 Xavier Neys (RETIRED) gentoo-dev 2007-04-19 15:41:14 UTC
(In reply to comment #3)
> Fixed in cvs.

Thanks.

> amd64, you lost your keyword on this bump.

I guess it's because the chmods that Lance added fail on amd64. The sed I added later on fails as well, of course. See bug #173748

FYI, I test gorg on amd64,hppa,sparc,ppc,mips,alpha,x86 and hardened/x86 but I had not tested the ebuild from the official tree.
The 0.6.3-r1 in my overlay was tested on amd64.

Hth
Comment 5 Richard Brown (RETIRED) gentoo-dev 2007-04-21 10:25:59 UTC
Created attachment 116882 [details, diff]
gorg-0.6.3-r1.patch

neysx, I tried to ping you on irc about this. I've attached a patch against the -r1 ebuild in your overlay which I'd like to commit if you've no problem with it, as it will resolve another couple of bugs as well. The only remaining question I have is would you accept a patch to gorg to make BindAddress part of the config, with a default of nil? Or did someone specifically want to make gorg listen only on 127.0.0.1?
Comment 6 Xavier Neys (RETIRED) gentoo-dev 2007-04-23 08:36:24 UTC
(In reply to comment #5)
> gorg-0.6.3-r1.patch
> 
> I've attached a patch against the
> -r1 ebuild in your overlay which I'd like to commit if you've no problem with
> it, as it will resolve another couple of bugs as well.

You should know better, you're the ebuild writer :)
Looks fine to me. I see no difference in the end result.
You'll want to remove some arches, though. Some dependencies would need to be keyworded first for sparc/mips/alpha/hppa.
If your ebuild fixes other issues, by all means, please do commit it.
Thanks a lot for your fixes.

> The only remaining question I have is would you accept a patch to gorg to make BindAddress part of
> the config, with a default of nil? Or did someone specifically want to make
> gorg listen only on 127.0.0.1?

I did :) Actually, I had not specified any address on purpose to prevent people from exposing webrick. The sed was required because of a change of behaviour in webrick.
Now that a listen address is required, I'll just add a listenAddress param to a later release.
Comment 7 Richard Brown (RETIRED) gentoo-dev 2007-04-23 17:17:45 UTC
Fixed in CVS (gorg-0.6.3-r1)