Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 175024 - net-misc/tinc init.d script enhancements
Summary: net-misc/tinc init.d script enhancements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Daniel Black (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-18 06:54 UTC by Natanael Copa
Modified: 2007-09-07 08:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
tincd-initd.patch (tincd-initd.patch,885 bytes, patch)
2007-04-18 06:57 UTC, Natanael Copa
Details | Diff
Patch to fix AWK errors (tincd.diff,833 bytes, patch)
2007-08-20 08:49 UTC, Eduardo Tongson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Natanael Copa 2007-04-18 06:54:57 UTC
The tincd init.d script looks very strange:

if [ ! `grep -c '^ *NETWORK:' /etc/conf.d/tinc.networks` > 0 ]
then
   ...

It does things I believe the author didn't really want it to do, like creating a file '0'.
Comment 1 Natanael Copa 2007-04-18 06:57:06 UTC
Created attachment 116607 [details, diff]
tincd-initd.patch

Does what I believe the author meant to do.

Also removes a useless use of cat and grep.
http://partmaps.org/era/unix/award.html
Comment 2 Natanael Copa 2007-04-18 06:59:47 UTC
btw.. the --kill=9 looks suspicious too. You should never shutdown a process with signal 9 since it never gives the process a chance to properly shutdown network connections or close files.
Comment 3 Daniel Black (RETIRED) gentoo-dev 2007-04-19 08:45:04 UTC
added - thanks. let me know if i broke the script.
Comment 4 Eduardo Tongson 2007-08-20 08:49:51 UTC
Created attachment 128656 [details, diff]
Patch to fix AWK errors

Fixes the AWK errors. Just copied the line from start().
Comment 5 Philipp Riegger 2007-09-02 11:23:46 UTC
Could this be reopened/fixed, please? Also the "reload" line needs to be checked/fixed.
Comment 6 Eduardo Tongson 2007-09-07 08:53:14 UTC
Phillipp, try my patch above.