Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 174877 - profile parent files containing comments
Summary: profile parent files containing comments
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-17 08:16 UTC by Ciaran McCreesh
Modified: 2007-04-22 14:14 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ciaran McCreesh 2007-04-17 08:16:20 UTC
According to PMS, which is in turn according to vapier, parent files can't contain comments. The following profiles (along with the person who added them) currently do:

default-linux/amd64/vserver/parent (hollow)
default-linux/sparc/sparc32/2006.0/2.4/parent (gustavoz)
default-linux/sparc/sparc32/2006.1/2.4/parent (gustavoz)
default-linux/sparc/sparc64/2006.0/2.4/parent (gustavoz)
default-linux/sparc/sparc64/2006.1/2.4/parent (gustavoz)
default-linux/x86/vserver/no-nptl/parent (phreak)
default-linux/x86/vserver/parent (hollow)
hardened/amd64/multilib/parent (solar)

Ideally, these should be fixed. If there's a serious reason for comments to be allowed in parent, this can turn into a PMS bug instead.
Comment 1 solar (RETIRED) gentoo-dev 2007-04-17 17:20:01 UTC
Mike,
Whats the logic for profile parents not containing comments?

----
hardened/amd64/multilib/parent (updated)
Comment 2 Gustavo Zacarias (RETIRED) gentoo-dev 2007-04-17 18:05:07 UTC
Once upon a time someone (don't remember who) said every file in the profiles should have the copyright header.
Since it's not such a deal they've been removed.
Comment 3 SpanKY gentoo-dev 2007-04-18 12:27:37 UTC
i was documenting existing behavior ... if we find comments in the file useful and portage supports it, then no reason to be so anal ...
Comment 4 Danny van Dyk (RETIRED) gentoo-dev 2007-04-22 14:14:44 UTC
All fixed.