Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 174045 - net-misc/l7-filter-2.9r fails to patch sys-kernel/gentoo-sources-2.6.19-r5
Summary: net-misc/l7-filter-2.9r fails to patch sys-kernel/gentoo-sources-2.6.19-r5
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Daniel Black (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-10 16:25 UTC by Chris Carlin
Modified: 2007-04-12 12:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
kernel-2.6.18-2.6.19-layer7-2.9.patch-9812.out (patch.out,13.23 KB, text/plain)
2007-04-10 16:29 UTC, Chris Carlin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Carlin 2007-04-10 16:25:57 UTC
Attempting to emerge net-misc/l7-filter-2.9 against sys-kernel/gentoo-sources-2.6.19-r5:

* Failed Patch: kernel-2.6.18-2.6.19-layer7-2.9.patch !
 *  ( /var/tmp/portage/net-misc/l7-filter-2.9/work/netfilter-layer7-v2.9/kernel-2.6.18-2.6.19-layer7-2.9.patch )
 * 
 * Include in your bugreport the contents of:
 * 
 *   /var/tmp/portage/net-misc/l7-filter-2.9/temp/kernel-2.6.18-2.6.19-layer7-2.9.patch-9812.out
Comment 1 Chris Carlin 2007-04-10 16:29:28 UTC
Created attachment 115913 [details]
kernel-2.6.18-2.6.19-layer7-2.9.patch-9812.out

It seems the various files the patch attempted to change just don't exist in the linux source tree.
Comment 2 Chris Carlin 2007-04-11 14:40:51 UTC
Nevermind. I reemerged my kernel and the l7-filter patch worked fine. Looks like I had a dirty source tree for some reason.

It might be advisable to include a notice during the merge that this is something to watch out for...
Comment 3 Daniel Black (RETIRED) gentoo-dev 2007-04-12 12:11:48 UTC
I can't think of a meaningfun notify for a failed patch. its either a incompatible kernel or modified by the user and i can't tell the difference.

I'm happy the pre/post install message covers this.

        ewarn "This may not work with all kernels. If it does not work please enter a bug at bugs.gentoo.org"
        ewarn "This only patches the current kernel source code. (${KV_DIR})"
        ewarn "Its up to you to recompile the kernel with the l7 options"


Thanks for solving this before i looked too deeply.
Comment 4 Chris Carlin 2007-04-12 12:44:17 UTC
Well honestly the "please file a bug" message encouraged me to file a bug quickly before poking at it myself first :)

I think that you could catch the failed patch and include something along the lines of the following statement:

"Patching of the kernel failed. Often this is caused by a kernel source that has been modified. You might want to re-emerge your kernel sources and try this package again."