Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 173909 - media-sound/alsa-driver-1.0.14_rc1 fails w/ kernel 2.6.20
Summary: media-sound/alsa-driver-1.0.14_rc1 fails w/ kernel 2.6.20
Status: VERIFIED WORKSFORME
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-09 13:15 UTC by Joris Van den Bogerd
Modified: 2007-04-09 14:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
emerge info (emerge_info.txt,3.00 KB, text/plain)
2007-04-09 13:17 UTC, Joris Van den Bogerd 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joris Van den Bogerd 2007-04-09 13:15:35 UTC 
Upon upgrading to gentoo-sources-2.6.20-r5 reinstalling the alsa-driver package fails to compile properly.  Problem relates to the pci_save_state and pci_restore_state defined in /usr/include/linux/pci.h.

Reproducible: Always

Steps to Reproduce:
1.emerge -av alsa-driver
2.see the code compiling
3.see it error :)

Actual Results:  
In file included from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/sound/driver.h:46,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/sound/opl3.h:54,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3/../../alsa-kernel/drivers/opl3/opl3_synth.c:22,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3/opl3_synth.c:2:
/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h: In function 'snd_pci_orig_save_state':
/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h:1134: error: too many arguments to function 'pci_save_state'
/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h: In function 'snd_pci_orig_restore_state':
/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h:1138: error: too many arguments to function 'pci_restore_state'
make[5]: *** [/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3/opl3_synth.o] Error 1
make[5]: *** Waiting for unfinished jobs....
In file included from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/sound/driver.h:46,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/sound/opl3.h:54,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3/opl3_lib.c:26:
/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h: In function 'snd_pci_orig_save_state':
/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h:1134: error: too many arguments to function 'pci_save_state'
/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h: In function 'snd_pci_orig_restore_state':
/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h:1138: error: too many arguments to function 'pci_restore_state'
make[5]: *** [/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3/opl3_lib.o] Error 1
In file included from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h:892,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/sound/driver.h:46,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/sound/opl3.h:54,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3/../../alsa-kernel/drivers/opl3/opl3_voice.h:22,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3/../../alsa-kernel/drivers/opl3/opl3_seq.c:25,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3/opl3_seq.c:1:
include/linux/pci.h:531: error: expected identifier or '(' before numeric constant
In file included from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/sound/driver.h:46,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/sound/opl3.h:54,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3/../../alsa-kernel/drivers/opl3/opl3_voice.h:22,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3/../../alsa-kernel/drivers/opl3/opl3_seq.c:25,
                 from /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3/opl3_seq.c:1:
/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h: In function 'snd_pci_orig_save_state':
/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h:1134: error: too many arguments to function 'pci_save_state'
/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h: In function 'snd_pci_orig_restore_state':
/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/include/adriver.h:1138: error: too many arguments to function 'pci_restore_state'
make[5]: *** [/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3/opl3_seq.o] Error 1
make[4]: *** [/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers/opl3] Error 2
make[3]: *** [/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1/drivers] Error 2
make[2]: *** [_module_/var/tmp/portage/media-sound/alsa-driver-1.0.14_rc1/work/alsa-driver-1.0.14rc1] Error 2
make[1]: *** [modules] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.20-gentoo-r5'
make: *** [compile] Error 2

Expected Results:  
Compiled successfully.

The pci_save_state and pci_restore_state seem to be not implemented.

As taken from pci.h

static __inline__ int pci_save_state(struct pci_dev *dev) { return 0; }
static __inline__ int pci_restore_state(struct pci_dev *dev) { return 0; }

Plus alsa-driver calls the method with too many params.
Comment 1 Joris Van den Bogerd 2007-04-09 13:17:36 UTC 
Created attachment 115821 [details]
emerge info
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-04-09 13:18:54 UTC 
Not baselayout.
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2007-04-09 13:21:06 UTC 
You need 1.0.14_rc3 for 2.6.20 kernels.
Comment 4 Joris Van den Bogerd 2007-04-09 14:57:07 UTC 
(In reply to comment #3)
> You need 1.0.14_rc3 for 2.6.20 kernels.
> 

rc3 works.