The "flexbackup-1.2.1-secure-tempfile.patch" introduced in flexbackup-1.2.1-r2 to increase the uniqueness of the temporary files inadvertently broke the remote buffer test used when flexbackup backs up remote hosts. Although the patch author properly manages temporary files on the remote host during the actual backup, during the remote buffer test (in the test_bufferprog() function) the temporary directory is not created on the remote machine. There's also a weakness in the code that parses the messages retrieved from the remote host: flexbackup is actually not detecting the failure and is reporting success even though the remote buffer tests aren't actually run. I've included a patch that adds the code to properly create the temporary directory on the remote host (and delete it when the test is done) and improves the parsing of the results so that failures like this aren't missed. The patch was generated against flexbackup-1.2.1-r3 and is additive to all the patches that that ebuild currently applies. - John
Created attachment 115669 [details, diff] Patch fixes remote buffer test.
This fix is in Portage now as flexbackup-1.2.1-r4 thanks to the help of the Gentoo Sunrise team.
