Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 173471 - cross-msp430/binutils add support for "$" in identifiers
Summary: cross-msp430/binutils add support for "$" in identifiers
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Toolchain Maintainers
URL: http://tinyos.cvs.sourceforge.net/tin...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-05 14:33 UTC by Aurélien Francillon
Modified: 2008-01-23 16:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
toolchain-binutils.ecalss.msp340_dollar_indentifiers.patch (toolchain-binutils.ecalss.msp340_dollar_indentifiers.patch,422 bytes, patch)
2007-04-05 14:35 UTC, Aurélien Francillon
Details | Diff
binutils_tinyos_dollar_support.patch (binutils_tinyos_dollar_support.patch,580 bytes, patch)
2007-04-05 14:37 UTC, Aurélien Francillon
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aurélien Francillon 2007-04-05 14:33:07 UTC
Hi, 
Tinyos needs support for dollars in identifiers in binutils,
on binutils for msp430 does not support it by default, 
the fix can be either a sed line in toolchain-binutils.eclass or 
a patch. Don't know the preferred method so i will provide both...
both applies for cross-msp430/binutils-2.17.50.0.14 but should apply to most binutils version without trouble ...
There should be no impact out of msp430 target as the only file touched 
is specific to msp430.
The change is essentially what's done in tinyos default toolchain, see URL.
Tested on tinyos/telosb motes...
Comment 1 Aurélien Francillon 2007-04-05 14:35:22 UTC
Created attachment 115510 [details, diff]
toolchain-binutils.ecalss.msp340_dollar_indentifiers.patch

patch for toolchain-binutils.ecalss
Comment 2 Aurélien Francillon 2007-04-05 14:37:38 UTC
Created attachment 115511 [details, diff]
binutils_tinyos_dollar_support.patch

use toolchain-binutils.ecalss.msp340_dollar_indentifiers.patch OR binutils_tinyos_dollar_support.patch both does the same thing...
Comment 3 SpanKY gentoo-dev 2007-04-07 09:14:32 UTC
i'm tired of juggling these things ... either tinyos needs to stop using $ in its symbols, or they need to take it up with the msp430/avr maintainers and get it changed in binutils

in the latter case, re-open and i'll merge the patch with the idea being that we'll be carrying it only for older versions, not newer
Comment 4 Aurélien Francillon 2007-04-11 12:21:26 UTC
Ok, I understand your position, 
however (and for the record) i just noticed that the 
ebuild for binutils-2.16.1-r3 has the patch for '$' for msp430 too. 
i guess you won't port it to next versions ... however this version of binutils can be used for tinyos ... 
sorry for the "noise" 
Comment 5 SpanKY gentoo-dev 2007-04-11 12:30:21 UTC
it sucks to be the guy in the middle (aka you) who just wants this stuff to work

i'll see about starting a thread on the binutils list on the topic
Comment 6 Aurélien Francillon 2007-04-12 06:21:41 UTC
(In reply to comment #5)
> it sucks to be the guy in the middle (aka you) who just wants this stuff to
> work

;), yes and tinyos devs are not really upstream friendly, they tend to keep 
all their changes in their own cvs, rarely pushed to upstream... 


> i'll see about starting a thread on the binutils list on the topic

that would be very nice, and i'm probably lacking the binutils background 
to be successful in doing this myself...


Comment 7 SpanKY gentoo-dev 2008-01-23 16:50:09 UTC
*** Bug 207161 has been marked as a duplicate of this bug. ***