Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 172946 - sys-apps/suspend2-userui-0.7.0 is always built statically
Summary: sys-apps/suspend2-userui-0.7.0 is always built statically
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Alon Bar-Lev (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-01 00:10 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2007-04-01 08:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2007-04-01 00:10:13 UTC
# cd /usr/portage/sys-apps/suspend2-userui
# grep static suspend2-userui-0.7.0.ebuild
IUSE="fbsplash static"
        # allow for static linking for use in initramfs/initrd
        use static && LDFLAGS="${LDFLAGS} -static"
# ebuild suspend2-userui-0.6.4-r2.ebuild unpack &>/dev/null
# ebuild suspend2-userui-0.7.0.ebuild unpack &>/dev/null
# cd /var/tmp/portage/sys-apps
# diff -u suspend2-userui-0.6.4-r2/work/suspend2-userui-0.6.4/Makefile suspend2-userui-0.7.0/work/suspend2-userui-0.7.0/Makefile
--- suspend2-userui-0.6.4-r2/work/suspend2-userui-0.6.4/Makefile        2006-06-06 19:25:10.000000000 +0200
+++ suspend2-userui-0.7.0/work/suspend2-userui-0.7.0/Makefile   2007-01-16 23:16:46.000000000 +0100
@@ -1,5 +1,5 @@
 CFLAGS := -Wall -O3 -g
-LDFLAGS :=
+LDFLAGS :=

 DESTDIR :=
 PREFIX := /usr/local
@@ -22,10 +22,10 @@
        make -C $@ all

 suspend2ui_text: $(CORE_OBJECTS) userui_text.o
-       $(CC) $(LDFLAGS) $^ -o $@
+       $(CC) $(LDFLAGS) -static $^ -o $@

 suspend2ui_fbsplash: $(CORE_OBJECTS) fbsplash/userui_fbsplash.o
-       $(CC) $(LDFLAGS) $^ -o $@ $(FBSPLASH_LIBS)
+       $(CC) $(LDFLAGS) -static $^ -o $@ $(FBSPLASH_LIBS)

 suspend2ui_usplash: $(CORE_OBJECTS) usplash/userui_usplash.o
        $(CC) $(filter-out -static,$(LDFLAGS)) $^ -o $@ $(USPLASH_LIBS)
#

Either "static" USE flag should be deleted in this case, or simple patch to Makefile should be created.
Comment 1 Alon Bar-Lev (RETIRED) gentoo-dev 2007-04-01 08:00:34 UTC
You are right.
Upstream delivers a different behavior each release.
I will remove the use flag for now... I hope static behavior will be kept.