17232 – smartmontools ebuild no honor CFLAGS

Bug 17232 - smartmontools ebuild no honor CFLAGS

Summary: smartmontools ebuild no honor CFLAGS

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Linux bug wranglers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2003-03-10 11:53 UTC by Paul Thompson
Modified:	2003-03-10 12:19 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
make smartmontools ebuild honor CFLAGS (smartmontools-diff,335 bytes, patch) 2003-03-10 11:54 UTC, Paul Thompson	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paul Thompson 2003-03-10 11:53:27 UTC

Here is (whitespace dammaged) fix:
(patch is also attached)

--- smartmontools-5.0.45.ebuild.orig    2003-03-10 11:43:53.000000000 -0500
+++ smartmontools-5.0.45.ebuild 2003-03-10 11:44:27.000000000 -0500
@@ -14,6 +14,9 @@
 S=${WORKDIR}/${MY_P}
 
 src_compile() {
+       cp Makefile Makefile.orig
+       sed -e "/^CFLAGS/c CFLAGS = -fsigned-char ${CFLAGS}" < Makefile.orig \
+               > Makefile
        emake || die
 }

Comment 1 Paul Thompson 2003-03-10 11:54:35 UTC

Created attachment 9214 [details, diff]
make smartmontools ebuild honor CFLAGS

Comment 2 SpanKY gentoo-dev

2003-03-10 12:19:45 UTC

no reason to edit the makefile ... you can just pass it on the `make` cmd line ...

http://cvs.gentoo.org/cgi-bin/viewcvs.cgi/gentoo-x86/sys-apps/smartmontools/smartmontools-5.0.45.ebuild.diff?r1=1.4&r2=1.5