Bug 172232 – media-video/mplayer need of splitting aac and mp3 flags

• Status: RESOLVED WORKSFORME
• Product: Gentoo Linux

[Description Yaroslav Isakov 2007-03-25 20:46:16 UTC]

Hello, I propose that media-video/mplayer ebuild need of splitting encode and decode flags. For example, I may need ONLY internal faad and mp3lib, but encode x264. In this situation and current ebuild there will be installed lame and faac, which I don't need :(. I propose flags aac-encode and mp3-encode for encoding and usual aac and mp3 for decoding.

PS. Sorry for my very BAD english

[Comment 1 Steve Dibb (RETIRED) 2007-03-28 13:45:27 UTC]

We already have the encode use flag for that very purpose.  If you have encode + aac, it will pull in faac.

Fixed the use flag checks a bit though to pull in twolame only if encode is set.

[Comment 2 Yaroslav Isakov 2007-03-28 20:37:47 UTC]

But I want +encode (for xvid/x264) and faad/mp3lib BUT without faac/lame

[Comment 3 Yaroslav Isakov 2007-03-28 20:41:26 UTC]

And I'am talking about lame, not twolame, but anyway, thanks for this cleaning

[Comment 4 Yaroslav Isakov 2007-03-28 21:05:10 UTC]

Created attachment 114821 [details, diff]
mplayer-1.0_rc2_pre20070321-r4.ebuild.patch

Patch for last ebuild, which show my idea on splitting of flags

[Comment 5 Yaroslav Isakov 2007-03-28 21:06:15 UTC]

Created attachment 114823 [details, diff]
mplayer-1.0_rc2_pre20070321-r4.ebuild-experimental.patch

Patch for experimental flags faac/faad and lame/mp3lib splitting

[Comment 6 Jakub Moc (RETIRED) 2007-06-25 15:43:06 UTC]

So; you've replaced mp3 with lame and aac with faac and introduced a totally redundant mp3lib use flag which is doing exactly the same what mp3 has been doing until now. Kindly explain what kind of sense does this make.

Until then, WORKSFORME, absolutely no need to confuse users.