Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 171984 - media-video/mplayer-1.0_rc2_pre20070321-r2 doesn't properly use configure's script --language option
Summary: media-video/mplayer-1.0_rc2_pre20070321-r2 doesn't properly use configure's s...
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-24 00:01 UTC by Angel Olivera
Modified: 2007-03-24 01:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed fixed ebuild. (mplayer-1.0_rc2_pre20070321-r2.ebuild,16.48 KB, text/plain)
2007-03-24 00:01 UTC, Angel Olivera
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Angel Olivera 2007-03-24 00:01:05 UTC
When building mplayer with a non-empty $LINGUAS, repeated "--language" options are passed to the configure script, which ends up building mplayer only with support for the last language it is entered.

For example, `USE="linguas_es" emerge mplayer' would use: "configure --language=en --language=es" but the proper syntax is "configure --language=en,es", as described by:

  --language=list        a white space or comma separated list of languages for
                         translated man pages, the first language is used for
                         messages and the GUI (the environment variable
                         $LINGUAS is also honored) [en]
                         (Available: bg cs de dk el en es fr hu it ja ko mk nb nl pl ro ru sk sv tr uk pt_BR zh_CN zh_TW all)


Reproducible: Always



Expected Results:  
mplayer should be built with support for English and all of your configured LINGUAS.

The fix is trivial:

--- 1/mplayer-1.0_rc2_pre20070321-r2.ebuild     2007-03-23 20:25:15.000000000 -0300
+++ 2/mplayer-1.0_rc2_pre20070321-r2.ebuild     2007-03-23 20:25:47.000000000 -0300
@@ -221,7 +221,7 @@
        local myconf_linguas="--language=en"
        for x in ${LANGS}; do
                if use linguas_${x}; then
-                       myconf_linguas="${myconf_linguas} --language=${x}"
+                       myconf_linguas="${myconf_linguas},${x}"
                fi
        done
        myconf="${myconf} ${myconf_linguas}"
Comment 1 Angel Olivera 2007-03-24 00:01:52 UTC
Created attachment 114197 [details]
Proposed fixed ebuild.
Comment 2 Steve Dibb (RETIRED) gentoo-dev 2007-03-24 00:38:28 UTC
Already fixed in -r3

thanks, though
Comment 3 Angel Olivera 2007-03-24 00:43:14 UTC
Ouch, I thought syncing last night was going to be enough. My bad, thanks.
Comment 4 Steve Dibb (RETIRED) gentoo-dev 2007-03-24 00:55:25 UTC
(In reply to comment #3)
> Ouch, I thought syncing last night was going to be enough. My bad, thanks.
> 

That's fine, as I committed it just this morning.

Another LINGUAS issue did come up though, and I mentioned it on this forum sticky if you'd like to follow progress or comment, both are welcome.

http://forums.gentoo.org/viewtopic-t-548568-highlight-.html
Comment 5 Wolfram Schlich (RETIRED) gentoo-dev 2007-03-24 01:56:30 UTC
Pretty cool -- I just got a swedish -r2 mplayer...
jag heter wolfram, vem ar du? ;)