Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 171529 - net-wireless/madwifi-ng version bump to 0.9.3 (ebuild attached)
Summary: net-wireless/madwifi-ng version bump to 0.9.3 (ebuild attached)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Steev Klimaszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-20 07:39 UTC by Gordon Malm (RETIRED)
Modified: 2007-03-21 15:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
madwifi-ng-0.9.3.ebuild (madwifi-ng-0.9.3.ebuild,2.75 KB, text/plain)
2007-03-20 07:40 UTC, Gordon Malm (RETIRED)
Details
madwifi-ng-0.9.3-uudecode-gcda-fix.patch (madwifi-ng-0.9.3-uudecode-gcda-fix.patch,333 bytes, patch)
2007-03-20 07:40 UTC, Gordon Malm (RETIRED)
Details | Diff
madwifi-ng-0.9.3.ebuild-rev02 (madwifi-ng-0.9.3.ebuild-rev02,2.73 KB, text/plain)
2007-03-20 08:02 UTC, Gordon Malm (RETIRED)
Details
madwifi-build_all_ratemods.patch (madwifi-build_all_ratemods.patch,3.06 KB, patch)
2007-03-20 15:15 UTC, Gordon Malm (RETIRED)
Details | Diff
madwifi-build_all_ratemods-rev2.patch (madwifi-build_all_ratemods-rev2.patch,3.02 KB, patch)
2007-03-20 19:09 UTC, Gordon Malm (RETIRED)
Details | Diff
Fixes issues in comment #10 (madwifi-ng-0.9.3-r1-to-r2.patch,783 bytes, patch)
2007-03-21 15:02 UTC, Gordon Malm (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gordon Malm (RETIRED) gentoo-dev 2007-03-20 07:39:37 UTC
This is my first attempt at ebuild writing other than patching small bits so please review/test.  It is based off the madwifi-ng-0.9.2 ebuild.

The madwifi-ng-tools-0.9.2 ebuild can simply be copied to madwifi-ng-tools-0.9.3 I believe.  Atleast that is what I did for the moment.

Compiles, installs and works on x86/hardened hostapd machine.  Clients have connectivity.  Very little testing otherwise.  Have not tried it with wpa_supplicant yet, too late, need sleep.

Reproducible: Always
Comment 1 Gordon Malm (RETIRED) gentoo-dev 2007-03-20 07:40:33 UTC
Created attachment 113835 [details]
madwifi-ng-0.9.3.ebuild
Comment 2 Gordon Malm (RETIRED) gentoo-dev 2007-03-20 07:40:56 UTC
Created attachment 113836 [details, diff]
madwifi-ng-0.9.3-uudecode-gcda-fix.patch
Comment 3 Gordon Malm (RETIRED) gentoo-dev 2007-03-20 08:02:51 UTC
Created attachment 113838 [details]
madwifi-ng-0.9.3.ebuild-rev02

revised ebuild (obsoletes madwifi-ng-0.9.3.ebuild attachment):
-testing (~) not stable
-don't export variables
Comment 4 Steev Klimaszewski (RETIRED) gentoo-dev 2007-03-20 14:05:28 UTC
Very nice - the ARCH bit (well, really the src_compile() isn't needed at all) isn't necessary (that I have seen) - I actually bumped this last night sometime, and didn't get this bug until this morning.  Great work though, and look forward to hearing from you if there are any bugs (aside from a few known ones ;) )
Comment 5 Gordon Malm (RETIRED) gentoo-dev 2007-03-20 15:14:18 UTC
One issue.  With madwifi-ng-0.9.3 rate control module selection is done at module load time instead of compile time as in madwifi-ng-0.9.2*.  No special USE flags or any related stuff is needed.  Patch against the madwifi-ng-0.9.3.ebuild in portage incoming now.

Regarding the ARCH stuff: You are correct, I get rid of src_compile() and no problems.  I was getting ARCH mismatch errors related to madwifi's ARCH detection script, scripts/get_arch.mk while I was working on this but not anymore. *shrug*
Comment 6 Gordon Malm (RETIRED) gentoo-dev 2007-03-20 15:15:08 UTC
Created attachment 113878 [details, diff]
madwifi-build_all_ratemods.patch
Comment 7 Steev Klimaszewski (RETIRED) gentoo-dev 2007-03-20 16:48:28 UTC
Good catch - when I get out of work, I will apply and bump
Comment 8 Gordon Malm (RETIRED) gentoo-dev 2007-03-20 19:09:49 UTC
Created attachment 113910 [details, diff]
madwifi-build_all_ratemods-rev2.patch

BUILD_PARAMS variable is also no longer used.  I missed removing that in the first patch.
Comment 9 Steev Klimaszewski (RETIRED) gentoo-dev 2007-03-21 00:24:10 UTC
Bumped and added to CVS - Thanks for the work on this :)
Comment 10 Daniel Drake (RETIRED) gentoo-dev 2007-03-21 13:46:50 UTC
Some issues with the latest ebuild:

BUILD_PARAMS has been removed, now madwifi builds against the running kernel rather than the one in /usr/src/linux and this is not the correct behaviour

IUSE is missing from the ebuild

Using ${PN}-${PV} is redundant, use ${P} instead (in the epatch line)
Comment 11 Gordon Malm (RETIRED) gentoo-dev 2007-03-21 15:02:33 UTC
Created attachment 113972 [details, diff]
Fixes issues in comment #10

Those are my fault entirely.  Sorry, still learning.  Here is a patch against -r1.  Thank you for the constructive feedback.
Comment 12 Daniel Drake (RETIRED) gentoo-dev 2007-03-21 15:43:21 UTC
Those changes look correct, thanks!
Comment 13 Steev Klimaszewski (RETIRED) gentoo-dev 2007-03-21 15:53:14 UTC
Fixed, I hope.  Added IUSE after it was pointed out that it is a MUST apparently.  Repoman didn't complain, so I assumed it was correct.  If I keep screwing up the ebuild it will never get stabled ;)