Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 171346 - [PATCH] kde-base/kmail-3.5.6-r1: Fixes for various crash and hang bugs
Summary: [PATCH] kde-base/kmail-3.5.6-r1: Fixes for various crash and hang bugs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Carsten Lohrke (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-18 14:50 UTC by Peter Alfredsen (RETIRED)
Modified: 2007-04-11 22:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
kmail-3.5.6-crash-unfixed-filter-mails.patch (kmail-3.5.6-crash-unfixed-filter-mails.patch,1.66 KB, patch)
2007-03-18 14:52 UTC, Peter Alfredsen (RETIRED)
Details | Diff
kmail-3.5.6-debian-18_optimize_splitAddressInternal.diff (kmail-3.5.6-debian-18_optimize_splitAddressInternal.diff,4.85 KB, patch)
2007-03-18 14:53 UTC, Peter Alfredsen (RETIRED)
Details | Diff
kmail-3.5.6-imap-crash-svn-631934.patch (kmail-3.5.6-imap-crash-svn-631934.patch,3.40 KB, patch)
2007-03-18 14:55 UTC, Peter Alfredsen (RETIRED)
Details | Diff
kmail-3.5.6-imap-crash-svn-643329.patch (kmail-3.5.6-imap-crash-svn-643329.patch,1.41 KB, patch)
2007-03-18 14:56 UTC, Peter Alfredsen (RETIRED)
Details | Diff
kmail-3.5.6-crash-svn-643369.patch (kmail-3.5.6-crash-svn-643369.patch,958 bytes, patch)
2007-03-18 14:57 UTC, Peter Alfredsen (RETIRED)
Details | Diff
kmail-3.5.6-r2.ebuild (kmail-3.5.6-r2.ebuild,2.37 KB, text/plain)
2007-03-18 14:58 UTC, Peter Alfredsen (RETIRED)
Details
kmail.tar.bz2 (kmail.tar.bz2,14.64 KB, application/octet-stream)
2007-03-18 15:01 UTC, Peter Alfredsen (RETIRED)
Details
kmail-3.5.6-r1.patch (kmail-3.5.6-r2.patch,879 bytes, patch)
2007-03-18 20:06 UTC, Peter Alfredsen (RETIRED)
Details | Diff
kdepim-3.5.6-r1.patch (kdepim-3.5.6-r2.patch,857 bytes, patch)
2007-03-18 20:08 UTC, Peter Alfredsen (RETIRED)
Details | Diff
kmail-3.5.6-fixes.diff (kmail-3.5.6-fixes.diff,188.36 KB, patch)
2007-04-03 12:20 UTC, Carsten Lohrke (RETIRED)
Details | Diff
kmail-3.5.6-fixes.diff (kmail-3.5.6-fixes.diff,195.55 KB, patch)
2007-04-06 10:06 UTC, Carsten Lohrke (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Alfredsen (RETIRED) gentoo-dev 2007-03-18 14:50:13 UTC
See top of individual patches for detailed descriptions.

Reproducible: Always

Steps to Reproduce:
Comment 1 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-18 14:52:36 UTC
Created attachment 113648 [details, diff]
kmail-3.5.6-crash-unfixed-filter-mails.patch

http://bugs.debian.org/404032   ->
http://bugs.kde.org/139886      ->
http://bugs.kde.org/128593      ->
http://bugs.kde.org/108971

Status: Still not merged upstream

Bug#404032: kmail: crash when filtering mails into current folder
Michael Eyrich
Tue, 06 Feb 2007 08:26:00 -0800
Package: kmail
Version: 4:3.5.5.dfsg.1-6
Followup-For: Bug #404032

It looks like kmail does not honour multiple opens of the same mailbox
thus closing the current mailbox unmindful and crashes.

the attached (dirty) patch avoids closing a folder if already open.
Comment 2 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-18 14:53:36 UTC
Created attachment 113652 [details, diff]
kmail-3.5.6-debian-18_optimize_splitAddressInternal.diff

http://bugs.kde.org/137033 :
we have been shipping this patch in debian for a couple of months. We have gotten one report of some drawbacks with it, but I still consider them less imp$

 A user writes:
 <quote>
 Since version 4:3.5.5.dfsg.1-2  kmail stopped treating correctly my name in
 the header. The last à in my last name is lost (strangely enough if I write
 it not in the last position of my name in the profile it works without
 problem). Prior to that version it worked without problem. I suspect the
 culprit is
  18_optimize_splitAddressInternal.diff
 </quote>

 Original report is http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=405867

 /Sune
Comment 3 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-18 14:55:18 UTC
Created attachment 113654 [details, diff]
kmail-3.5.6-imap-crash-svn-631934.patch

http://websvn.kde.org/?view=rev&revision=631934

SVN commit 631934 by dfaure:

 Found the reason why KMAcctCachedImap::processNewMail's assert below was hit
   assert( mFolder );  // George says "better to crash then lose mail"
 The configuration dialog creates temporary copies of the account when modifying one;
 but it doesn't delete that copy when closing with Cancel. What's more, the copied account
 started its own timer for interval-mail-checking, and when that timer fired, KMAcctCachedImap
 would crash due to mFolder=0. So:
 1) delete things in the dtor to avoid the account memleak
 2) don't start the mailcheck timer when simply setting the checkinterval of an account,
    only when the account is added to the AccountManager for real.
 BUG: 117935
http://bugs.kde.org/117935
Comment 4 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-18 14:56:46 UTC
Created attachment 113657 [details, diff]
kmail-3.5.6-imap-crash-svn-643329.patch

http://websvn.kde.org/?view=rev&revision=643329

Revision 643329 - (view) (download) (as text) (annotate) - [select for diffs]
 Modified Fri Mar 16 21:54:53 2007 UTC (36 hours, 51 minutes ago) by coolo
File length: 77033 byte(s)
Diff to previous 643194
fix the recovery path patch - meanwhile we think we know

 Revision 643194 - (view) (download) (as text) (annotate) - [select for diffs]
 Modified Fri Mar 16 14:40:35 2007 UTC (44 hours, 6 minutes ago) by coolo
File length: 77029 byte(s)
Diff to previous 571100
Till says my patch looks correct for the recovery path
CCBUG: 126715
http://bugs.kde.org/126715
Comment 5 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-18 14:57:53 UTC
Created attachment 113658 [details, diff]
kmail-3.5.6-crash-svn-643369.patch

http://websvn.kde.org/?view=rev&revision=643369

Revision 643369 - (view) (download) (as text) (annotate) - [select for diffs]
 Modified Sat Mar 17 02:16:46 2007 UTC (32 hours, 41 minutes ago) by winterz
File length: 11631 byte(s)
Diff to previous 614050
backport SVN commit 643168 by coolo:

this looks crashy (and I guess this is the same with 3.5) (CID 3205)
Comment 6 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-18 14:58:45 UTC
Created attachment 113659 [details]
kmail-3.5.6-r2.ebuild

Ebuild for the patches
Comment 7 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-18 15:01:06 UTC
Created attachment 113660 [details]
kmail.tar.bz2

Tar of my kmail directory to be untarred under kde-base in case I forgot anything - I will be working 24/7 the next week or so.
Comment 8 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2007-03-18 16:19:14 UTC
(In reply to comment #6)
> Created an attachment (id=113659) [edit]
> kmail-3.5.6-r2.ebuild
> 
> Ebuild for the patches
> 

Please attach patches to ebuilds, not whole ebuilds.

Also please create the appropriate patch to kdepim ebuild.
Comment 9 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-18 19:59:50 UTC
(In reply to comment #8)
> (In reply to comment #6)
> > Created an attachment (id=113659) [edit]
> > kmail-3.5.6-r2.ebuild
> > 
> > Ebuild for the patches
> > 
> 
> Please attach patches to ebuilds, not whole ebuilds.

Gotcha. Hmm... That actually makes sense, now I think about it.

> Also please create the appropriate patch to kdepim ebuild.

Done. I can't build-test it for obvious reasons.
Comment 10 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-18 20:06:38 UTC
Created attachment 113703 [details, diff]
kmail-3.5.6-r1.patch

Patch against kmail-3.5.6-r1.ebuild.
Comment 11 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-18 20:08:45 UTC
Created attachment 113704 [details, diff]
kdepim-3.5.6-r1.patch

Patch against kdepim-3.5.6-r1.ebuild.
Comment 12 Carsten Lohrke (RETIRED) gentoo-dev 2007-04-03 12:20:50 UTC
Created attachment 115351 [details, diff]
kmail-3.5.6-fixes.diff

I'm not fond to include stuff that isn't in the 3.5 branch, especially if it attempts to solve a minor problem, as the second patch. Would you test the attached patch, please?! It includes basically all branch bug fixes, but not the new features. Simply replacing the PATCHES=... line with the patch should suffice. I don't use imap accounts, so this patch might even eat your kitty - hope not, though. ;)
Comment 13 Carsten Lohrke (RETIRED) gentoo-dev 2007-04-06 10:06:36 UTC
Created attachment 115548 [details, diff]
kmail-3.5.6-fixes.diff

minor changes to the above patch
Comment 14 Carsten Lohrke (RETIRED) gentoo-dev 2007-04-11 22:44:41 UTC
Please give kmail-3.5.6-r2 a try. Considering this bug fixed.