171217 – net-wireless/aircrack-ng-0.7-r1 - ~x86-fbsd keyword request

Bug 171217 - net-wireless/aircrack-ng-0.7-r1 - ~x86-fbsd keyword request

Summary: net-wireless/aircrack-ng-0.7-r1 - ~x86-fbsd keyword request

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All FreeBSD

Importance:	High enhancement (vote)
Assignee:	Gentoo/BSD Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-03-17 04:18 UTC by ebfe
Modified:	2007-03-18 08:55 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch for the ebuild (freebsd.patch,742 bytes, patch) 2007-03-17 04:19 UTC, ebfe	Details \| Diff
patch for process-group-leader.c (freebsd_testing.patch,400 bytes, patch) 2007-03-17 04:20 UTC, ebfe	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description ebfe 2007-03-17 04:18:40 UTC

since aircrack-ng-0.7-r1 can now build only the userland tools, it is now possible to build at least parts of the aircrack-ng suite on gentoo-freebsd.

aircrack-ng's wifi useflag has to be use.masked, as it won't build the monitor/capture tools on fbsd.

the are two patches required in order to get through the test. the new ebuild has been tested on gentoo-freebsd and amd64.


please name aircrack-ng-0.7-r2 and keyword ~x86-freebsd

Reproducible: Always

Comment 1 ebfe 2007-03-17 04:19:43 UTC

Created attachment 113546 [details, diff]
patch for the ebuild

aircrack-ng will bail out with a syntax error otherwise

Comment 2 ebfe 2007-03-17 04:20:30 UTC

Created attachment 113547 [details, diff]
patch for process-group-leader.c

patch to make setpgrp work in freebsd and x86

Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev

2007-03-17 07:53:11 UTC

(In reply to comment #2)
> Created an attachment (id=113547) [edit]
> patch for process-group-leader.c
> 
> patch to make setpgrp work in freebsd and x86
> 

Maybe setpgrp (0, 0) can be used for both?

Comment 4 ebfe 2007-03-17 10:12:50 UTC

the linux definition of setpgrp is setpgrp(void) while FreeBSD defines it as setpgrp(pid, pgrp). I've tested the patch and the test successfully runs on both x86-fbsd and amd64.

Comment 5 Alon Bar-Lev (RETIRED) gentoo-dev

2007-03-17 10:16:19 UTC

(In reply to comment #4)
> the linux definition of setpgrp is setpgrp(void) while FreeBSD defines it as
> setpgrp(pid, pgrp). I've tested the patch and the test successfully runs on
> both x86-fbsd and amd64.

Sorry!
Wrong paste...
What about setpgid (0,0)?

Comment 6 ebfe 2007-03-17 10:31:50 UTC

leads to the same behaviour and might in fact be considered better code :o)

0 for pgrp will use getpid() internally

Comment 7 Alon Bar-Lev (RETIRED) gentoo-dev

2007-03-17 10:40:27 UTC

Done.
bsd, can you please check it out at your side?
USE="-wifi" FEATURES="test"

Comment 8 Peter Weller (RETIRED) gentoo-dev

2007-03-18 08:55:35 UTC

Keyworded ~x86-fbsd, package.use.mask'd wifi USE flag.