Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 171040 - www-client/epiphany - patch to build with xulrunner
Summary: www-client/epiphany - patch to build with xulrunner
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-15 15:25 UTC by David Keijser
Modified: 2007-03-28 16:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
the patch (epiphany-2.16.3.ebuild.patch,1.48 KB, patch)
2007-03-15 15:28 UTC, David Keijser
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Keijser 2007-03-15 15:25:12 UTC
This is my first time trying to hack a ebuild, hopefully everything is working alright.

The patch makes the ebuild build epiphany with xulrunner if the xulrunner useflag is set, falling back on firefox otherwise(it should propably be the other way around as xulrunner is what should be used, but i didnt want to change to much)

Reproducible: Always

Steps to Reproduce:
Comment 1 David Keijser 2007-03-15 15:28:53 UTC
Created attachment 113364 [details, diff]
the patch
Comment 2 Mart Raudsepp gentoo-dev 2007-03-15 15:42:13 UTC
Worth noting is that the epiphany-2.18.0 ebuild in the gnome-experimental overlay already supports xulrunner. This will be moved to portage as soon as we get around to that in our GNOME-2.18 introduction to the tree.

However your patch has a couple things different, such as the minimum xulrunner version and such. We should doublecheck that we aren't missing by accident a minimum version on xulrunner in the overlay ebuild.

2.16 epiphany didn't have xulrunner support because at the time it was problematic - quite new support for epiphany iirc, plus the xulrunner versions in tree at the time weren't all that mature
Comment 3 David Keijser 2007-03-15 16:08:33 UTC
the minimum xulrunner version was added becouse it was the only version i tested with (it was also the only version available in my portage tree).
Comment 4 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-03-15 18:38:57 UTC
This will get into portage with 2.18.0.  I've been using it for the whole 2.17.x dev cycle, and it works fine.  If you need it now, feel free to try the overlay, which has most of 2.18.0 in it at this point.
Comment 5 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-03-28 14:18:18 UTC
2.18.0 is in the tree, although masked at the moment for testing.
Comment 6 David Keijser 2007-03-28 16:19:47 UTC
I tried epiphany 2.18 and it builds just fine.