Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 170503 - Patch to xfdesktop-4.4.0-r3.ebuild: "dbus" USE flag presence should not imply dependence on Thunar
Summary: Patch to xfdesktop-4.4.0-r3.ebuild: "dbus" USE flag presence should not imply...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-11 22:10 UTC by Dave Armstrong
Modified: 2007-03-13 21:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
xfdesktop-4.4.0-r3.ebuild.diff (xfdesktop-4.4.0-r3.ebuild.diff,1.25 KB, patch)
2007-03-11 22:11 UTC, Dave Armstrong
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Armstrong 2007-03-11 22:10:02 UTC
Xfdesktop (4.4.0-r3) depends on Thunar when the "dbus" use flag is present.  Such is less than optimal in terms of flexibility, and is inconsistent with the builds from Xfce 4.2.  Attached is a patch to xfdesktop-4.4.0-r3.ebuild that adds more explicit control over whether to build and install Thunar in addition to xfdesktop.  In addition, an upgrade from 4.2 to 4.4 will not by default change the desktop behavior.  Thunar is only necessary for adding icons to the desktop.

Reproducible: Always
Comment 1 Dave Armstrong 2007-03-11 22:11:13 UTC
Created attachment 113019 [details, diff]
xfdesktop-4.4.0-r3.ebuild.diff
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-03-11 22:16:09 UTC
No; this patch is just wrong, there's absolutely no point to require two use flags to enable one feature. 
 
--enable-file-icons needs --enable-thunarx, and depends on dbus-glib -> thunar is needed, game over.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2007-03-11 22:28:19 UTC
You can disable the icons from Settings > Desktop even if you enable USE="dbus" and if you don't want it at all you can allways use package.use.
Comment 4 Dave Armstrong 2007-03-13 21:13:07 UTC
(In reply to comment #2)
> No; this patch is just wrong, there's absolutely no point to require two use
> flags to enable one feature. 

I agree that such behavior is undesirable, but it makes little sense to have a desktop-icon (and hence filemanager dependency) feature contingent upon the dbus USE flag.  Better would be to use a more descriptive flag (e.g., "desktop-icons"; or if there is a precedent, use it) that handles the dependencies.