Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 170049 - app-emulation/virtualbox-1.3.6 has bug in handling split kernels
Summary: app-emulation/virtualbox-1.3.6 has bug in handling split kernels
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Markus Ullmann (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-09 01:57 UTC by Hypnos
Modified: 2007-03-19 15:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
virtualbox-1.3.6.ebuild-split-kernel.patch (virtualbox-1.3.6.ebuild-split-kernel.patch,736 bytes, patch)
2007-03-09 01:59 UTC, Hypnos
Details | Diff
virtualbox-1.3.6-split-kernel.patch (virtualbox-1.3.6-split-kernel.patch,679 bytes, patch)
2007-03-09 02:02 UTC, Hypnos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hypnos 2007-03-09 01:57:58 UTC
When the object dir is different from the source dir, the toplevel "Config.kmk" has typo which doesn't properly detect the source dir -- it just sets it to root.

Attached are patches to work around the bug.
Comment 1 Hypnos 2007-03-09 01:59:39 UTC
Created attachment 112659 [details, diff]
virtualbox-1.3.6.ebuild-split-kernel.patch

Corrects the typo.  It is possible that the method worked for older kernels, but the format of the Makefile it scans has changed.  I am using kernel 2.6.18-suspend-r1.
Comment 2 Hypnos 2007-03-09 02:02:02 UTC
Created attachment 112660 [details, diff]
virtualbox-1.3.6-split-kernel.patch

This is the patch to be applied to the source tree.
Comment 3 Kalin KOZHUHAROV 2007-03-09 08:36:28 UTC
Yup, I can confirm this bug here with KBUILD_OUTPUT used on
vanilla-sources-2.6.20.1

And I tested the patch, works-for-me.

BTW, this has been fixed in the trunk:

------------------------------------------------------------------------
r907 | vboxsync | 2007-02-15 00:01:05 +0900 (Thu, 15 Feb 2007) | 2 lines
Changed paths:
   M /trunk/Config.kmk

Config.kmk: support splitted Linux kernels

------------------------------------------------------------------------

I have added the two patches into my overlay[1] for easy testing.
BTW attachment 112660 [details, diff] had an extra whitespace in the first part.

[1] https://svn.tar.bz/repos/pkalin/trunk/app-emulation/virtualbox/

Feel free to add the above via layman.
HOWTO: https://svn.tar.bz/repos/pkalin/trunk/README.txt

I'll have a look at the other bug reports as well.

bug #170051 : fixed in my overlay
bug #167001 : no amd64 to test the new 1.3.6, please test if you can
bug #170051 : need more info


Somebody please fix in the official tree.

BTW, removing the wrapper USE flag might be a good idea, I wonder if anybody is
using it without the wrapper script...
Comment 4 Hypnos 2007-03-09 19:42:46 UTC
I am using this without the wrapper because I forgot to set the USE flag, but indeed it's annoying.  I agree that the wrapper should be installed by default.
Comment 5 Alessio Cassibba (X-Drum) 2007-03-14 22:17:52 UTC
(In reply to comment #3)
> 
> BTW, removing the wrapper USE flag might be a good idea, I wonder if anybody is
> using it without the wrapper script...
> 
Hi, some users don't like or use the wrapper script, they like to start 
the XPCOM server manually, this is useful for debugging purposes too
(some error messages are show there)

(In reply to comment #4)
> I am using this without the wrapper because I forgot to set the USE flag, but
> indeed it's annoying.  I agree that the wrapper should be installed by default.
> 
Hi again :)
expect an update soon: the wrapper script can be enabled by default without
problems, i think it's time to change the use flag "wrapper" in "nowrapper",
therefore users who don't want it will not lose the ability to choose 

Comment 6 Alessio Cassibba (X-Drum) 2007-03-19 13:36:13 UTC
(In reply to comment #0)
> When the object dir is different from the source dir, the toplevel "Config.kmk"
> has typo which doesn't properly detect the source dir -- it just sets it to
> root.
> 
> Attached are patches to work around the bug.
> 

hi, the problem still occurs with virtualbox-1.3.8?
Comment 7 Hypnos 2007-03-19 15:13:13 UTC
No, it seems to work fine for me now, thanks to the change upstream.

Closing bug!