xgammon is a backgammon game which has support for both multiplayer and singleplayer games. suggested placement is app-games. the patches are needed for the game to compile properly, there are three small patches, included in the xgammon-patches.tar.gz attachment.
Created attachment 535 [details] xgammon 0.98 ebuild.
Created attachment 536 [details] three patches for xgammon 0.98, all very small.
I was unable to attach the ChangeLog after commiting the ebuild. I'll dump it here (it can also be downloaded from <url: http://terje.kvernes.no/gentoo/xgammon/ChangeLog >. # ChangeLog for <CATEGORY>/<PACKAGE_NAME> # Copyright 2002 Gentoo Technologies, Inc.; Distributed under the GPL # /space/gentoo/cvsroot/gentoo-x86/skel.ChangeLog,v 1.2 2002/02/05 00:57:47 gbevin Exp *xgammon-0.98-r1 (11 Apr 2002) 11 Apr 2002; T.Kvernes <terjekv@math.uio.no> xgammon-0.98-r1: Initial ebuild, kludged about with the process due to broken behaviour from xgammon (amoungst other thing it expects "." in $PATH for root).
Hi Terje! The ebuild looks nice. A couple of minor comments. 1. I believe that xgammon-0.98a.ebuild is a valid ebuild name, which we would probably want to use (unless the "a" suffix was indicative of alpha status? see http://www.gentoo.org/doc/gentoo-howto.html ). This would allow us to use ${P}.tar.gz in the SRC_URI line and make the ebuild version independent. 2. Did you create the patches specifically for the Gentoo ebuild. If this is the case, they should probably be in the xgammon/files directory. I should have elaborated on Gentoo specific patches further in my reply to your gentoo-dev posting. I apologize for any confusion. I thought we were discussing third-party or upstream developer patches :). Normally gentoo specific patches created by the ebuild author are kept in the files directory. A suffix of "-gentoo" is typically appended to indicate this. For example, xgammon-0.98-gentoo-makefile.patch 3. Is the pkg_postinst function unnecessary? If you have any questions or comments, feel free to contact me at tod@gentoo.org Thanks for the contribution!
> Hi Terje! hi again Tod. :) > The ebuild looks nice. A couple of minor comments. > > 1. I believe that xgammon-0.98a.ebuild is a valid ebuild name, which > we would probably want to use (unless the "a" suffix was indicative > of alpha status? see http://www.gentoo.org/doc/gentoo-howto.html ). > This would allow us to use ${P}.tar.gz in the SRC_URI line and make > the ebuild version independent. I'm actually not sure why xgammon has this version scheme. but it's not alpha software, they just do it this way[tm]. > 2. Did you create the patches specifically for the Gentoo ebuild. no, the patches are part mine, part RedHats. both GPLed. > If this is the case, they should probably be in the xgammon/files > directory. I should have elaborated on Gentoo specific patches > further in my reply to your gentoo-dev posting. I apologize for any > confusion. I thought we were discussing third-party or upstream > developer patches :). these are upstream patches that have been sent to the maintainers, they just haven't done anything in a (long) while. don't hold your breath. > Normally gentoo specific patches created by the ebuild author are > kept in the files directory. A suffix of "-gentoo" is typically > appended to indicate this. For example, > xgammon-0.98-gentoo-makefile.patch okay. > 3. Is the pkg_postinst function unnecessary? er, yes, you can zap that. I uploaded the verbose version I kept around. and since you have that version you probably have http://terje.kvernes.no/gentoo/xgammon/xgammon-0.98-makefile.patch in the SRC_URI, which isn't needed. I chose to use (export PATH=$PATH:.; emake) instead of patching the makefile, as the makefile was generated with xmkmf. I never trust the output of xmkmf to resemble itself across Gentoo-installs. anyhow, I attached the correct ebuild. > If you have any questions or comments, feel free to contact me at > tod@gentoo.org hm, I'll CC this to you then. > Thanks for the contribution! nah, thank you for a great distro.
right, the little case about uploading stuff to bugzilla again. I use "create a new attachment" and fill in that form. when I submit bugzilla claims that the file has 0 size, I wonder if this is the "well known bugzilla bug". anyhow, the ebuild: # Copyright 1999-2002 Gentoo Technologies, Inc. # Distributed under the terms of the GNU General Public License, v2 or later # Maintainer: Terje Kvernes <terjekv@math.uio.no> # /space/gentoo/cvsroot/gentoo-x86/skel.ebuild,v 1.4 2002/03/12 16:05:09 tod Exp S=${WORKDIR}/${P} DESCRIPTION="xgammon is a very nice backgammon game for X" SRC_URI="http://fawn.unibw-hamburg.de/steuer/xgammon/Downloads/${P}.tar.gz http://terje.kvernes.no/gentoo/xgammon/xgammon-0.98-broken.patch http://terje.kvernes.no/gentoo/xgammon/xgammon-0.98-config.patch" HOMEPAGE="http://fawn.unibw-hamburg.de/steuer/xgammon/xgammon.html" DEPEND="virtual/x11" #RDEPEND="" src_unpack() { unpack ${P}.tar.gz cd ${S} patch -p1 < ${DISTDIR}/xgammon-0.98-broken.patch patch -p1 < ${DISTDIR}/xgammon-0.98-config.patch } src_compile() { xmkmf || die "xmkmf died" (export PATH=$PATH:.; emake) || die } src_install () { make DESTDIR=${D} install || die }
Hi Terje! I will give it a walk through the park, and see if we can't get this commited to app-games :) Thanks again.
this hasn't moved for two and a half months or so. is there anything missing or otherwise lacking that I can do to get the ebuild commited? I see that it's an old ebuild of mine, lacking ${P} use, but I doubt that would be a big issue. ;-)
