Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 168791 - net-libs/openh323-1.18.0 fails with linux-headers >= 2.6.19.2-r2
Summary: net-libs/openh323-1.18.0 fails with linux-headers >= 2.6.19.2-r2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Stefan Knoblich (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-28 21:17 UTC by Alexis Ballier
Modified: 2007-03-02 17:07 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2007-02-28 21:17:21 UTC
seems like linux/compiler.h has been removed now : 


In file included from ixjunix.cxx:491:
/var/tmp/portage/net-libs/openh323-1.18.0/work/openh323_v1_18_0/include/ixjlid.h:277:28: error: linux/compiler.h: No such file or directory

while searching I found this : 

http://www.openh323.org/pipermail/openh323/2004-August/069756.html

I'm not 100% sure if it's safe to remove it, but it seems to be.
Comment 1 Rémi Cardona (RETIRED) gentoo-dev 2007-03-01 18:33:45 UTC
It would help if you could try it out yourself and let us know if it helps. :) Thanks
Comment 2 Alexis Ballier gentoo-dev 2007-03-02 07:52:38 UTC
Bah... remvoving the line : #include <linux/compiler.h> seems fine.
grepping portage tree shows that some other packages already do the same thing.

Could anybody in toolchain confirm that it's safe to remove it ? (wrt to stable linux-headers and so on)
Perhaps it could deserve a rev bump in ~arch removing that offending include line.
(it had been added after bug #72448 but I dont hit that bug with linux-headers 2.6.20)

I'll commit the patch as soon as somebody from toolchain can confirm this is not just plain wrong.
Comment 3 SpanKY gentoo-dev 2007-03-02 16:53:21 UTC
i cant comment on older headers as that include is generally added because someone somewhere hit a failure so they started including files until things compiled again

in general though, no package should ever include <linux/compiler.h>, so that is a safe fix for sanitized linux-headers
Comment 4 Alexis Ballier gentoo-dev 2007-03-02 17:07:34 UTC
I commited the patch removing the offending, thanks mike for the explanation.