Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 168766 - net-mail/pflogsumm-1.1.0-r1 dsn patch for postfix-2.3 is incorrect
Summary: net-mail/pflogsumm-1.1.0-r1 dsn patch for postfix-2.3 is incorrect
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Andrej Kacian (RETIRED)
URL: http://forums.gentoo.org/viewtopic-t-...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-28 18:02 UTC by Kevin Parent
Modified: 2007-03-03 12:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
corrected patch (1.1.0-postfix-2.3-logs.patch,536 bytes, patch)
2007-02-28 22:37 UTC, Kevin Parent
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Parent 2007-02-28 18:02:42 UTC
The dsn patch included in the pflogsumm-1.10-r1 ebuild is incorrect.  The "dsn" portion is missing a space, causing the "delivered" section of the pflogsumm output to be zero.

ebuild patch contains this line:

+               /to=<([^>]*)>, (?:orig_to=<[^>]*>, )?relay=([^,]+), (?:conn_use=
[^,]+, )?delay=([^,]+), (?:delays=[^,]+, )?(?:dsn=[^,]+,)?status=(\S+)(.*)$/o) >
= 4)

dsn patch included with postfix-2.3.6 has this line:

+               /to=<([^>]*)>, (?:orig_to=<[^>]*>, )?relay=([^,]+), (?:conn_use=
[^,]+, )?delay=([^,]+), (?:delays=[^,]+, )?(?:dsn=[^,]+, )?status=(\S+)(.*)$/o) 
>= 4)

The error lies in the dsn portion.  The ebuild patch says:

... (?:dsn=[^,]+,) ...  and it should be:
... (?:dsn=[^,]+, ) ...

The space between the comma and the end parenthesis makes all the difference in the world.



Reproducible: Always

Steps to Reproduce:
1. emerge =pflogsumm-1.1.0-r1
2. run pflogsumm
3. check output for delivered count

Actual Results:  
see link http://forums.gentoo.org/viewtopic-t-539754-highlight-.html

Expected Results:  
delivered count should not be zero
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-02-28 18:40:14 UTC
Please, use attachments instead of pasting patches inline... It completely kills formatting and makes the thing unreadable.
Comment 2 Kevin Parent 2007-02-28 18:51:24 UTC
(In reply to comment #1)
> Please, use attachments instead of pasting patches inline... It completely
> kills formatting and makes the thing unreadable.
> 

Sorry about that.  I'll do that in the future, however, it's not a patch, it's just a portion of the patch - the relevant part.  Is it necessary for me to resubmit as an attachment(s), or is the post currently clear enough to resolve the issue? 
Comment 3 Kevin Parent 2007-02-28 22:37:26 UTC
Created attachment 111633 [details, diff]
corrected patch
Comment 4 Andrej Kacian (RETIRED) gentoo-dev 2007-03-03 12:28:17 UTC
Fixed in CVS, and forced on users by a -r2 revision bump. Kept stable keywords, since this is a trivial bugfix.

Thanks for your time, Kevin!