Bug 168526 – app-office/openoffice - ugly TrueType fonts (patch)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sébastien Benoit 2007-02-27 05:12:13 UTC]

TrueType fonts are crapy in OpenOffice even if FreeType is compiled with bytecode interpreter.

Reproducible: Always




I patched the source code to avoid this.  It is just a variable that is wrongly set and later used as parameter to FreeType functions.

[Comment 1 Sébastien Benoit 2007-02-27 05:14:11 UTC]

Created attachment 111374 [details, diff]
My own version of the offending file

It is a file found in the OOO-2_0_4.tar.bz2 in vlc/source/glyph

[Comment 2 Sébastien Benoit 2007-02-27 05:15:03 UTC]

(In reply to comment #0)
> TrueType fonts are crapy in OpenOffice even if FreeType is compiled with
> bytecode interpreter.
> 
> Reproducible: Always
> 
> 
> 
> 
> I patched the source code to avoid this.  It is just a variable that is wrongly

I forgot the version number: It is 2.0.4
> set and later used as parameter to FreeType functions.
> 

[Comment 3 Jakub Moc (RETIRED) 2007-02-27 06:21:28 UTC]

Uhm, could you please attach a unified diff instead of the whole file?

[Comment 4 Sébastien Benoit 2007-02-27 16:26:22 UTC]

Created attachment 111433 [details, diff]
OpenOffice FreeType Patch

Here is the asked unified diff.  I don't know if it is correct since I'm new to these tools.  Note that the build system of OpenOffice has already a patch for that file.  I modified the patched version, but I used the original file as the source for the diff command.  I hope it would be usefull since it is a problem that seems to affect a lot of people.

[Comment 5 Jakub Moc (RETIRED) 2007-02-27 16:30:01 UTC]

Thanks.

[Comment 6 Sébastien Benoit 2007-02-27 16:43:50 UTC]

May be a little explanation would be useful. The problem is with the way mnLoadFlags is set.  Since OpenOffice doesn't use the fontconfig ( may be false in a future release ) library to retreive the system and users fonts settings, the best if I understand the FreeType API documentation is to set it to FT_LOAD_DEFAULT.  This flag lets FreeType to use the native hinters ( The TrueType  bytecode interpreter for example ) if available.  It is not a perfect patch but for people using a BCI enabled FreeType, it is a quick workaround.  A better patch would require a rewrite of vcl/source/gcach_ftyp.cxx

[Comment 7 Andreas Proschofsky (RETIRED) 2007-03-15 21:51:16 UTC]

I guess this is most likely something for upstream. Did you try to file this bug at:

http://qa.openoffice.org/issues/

?

Also: Did you check if this is still a valid problem for OOo 2.1.0?

[Comment 8 Sébastien Benoit 2007-04-17 17:07:23 UTC]

I finaly managed to compile openoffice 2.1 and no fonts issue anymore on my configuration.

[Comment 9 Andreas Proschofsky (RETIRED) 2007-04-17 17:26:31 UTC]

Happy to see a bug vanishing by itself, closing.